Skip to content

Commit 20f07b7

Browse files
committed
GH-1068 - Switch to simple event type name for automatically created counters.
1 parent 78991f4 commit 20f07b7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

spring-modulith-observability/src/main/java/org/springframework/modulith/observability/support/CrossModuleEventCounterFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ private static class ModulithMetricsCustomizer implements Comparable<ModulithMet
9494

9595
private static final BiConsumer<Object, Builder> NO_OP = (event, builder) -> {};
9696
private static final Function<Object, Builder> DEFAULT_FACTORY = event -> Counter
97-
.builder(event.getClass().getName());
97+
.builder(event.getClass().getSimpleName());
9898

9999
public static final ModulithMetricsCustomizer DEFAULT = new ModulithMetricsCustomizer(Object.class, NO_OP);
100100

spring-modulith-observability/src/test/java/org/springframework/modulith/observability/support/CrossModuleEventCounterFactoryUnitTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.function.Consumer;
2626

2727
import org.junit.jupiter.api.Test;
28-
import org.springframework.modulith.observability.support.CrossModuleEventCounterFactory;
2928

3029
/**
3130
* Unit tests for {@link CrossModuleEventCounterFactory}.
@@ -43,7 +42,7 @@ void appliesCustomization() {
4342
factory.customize(SampleEvent.class, (__, builder) -> builder.tag("key", "value"));
4443

4544
assertCounter(new SampleEvent(), it -> {
46-
assertThat(it.getName()).isEqualTo(SampleEvent.class.getName());
45+
assertThat(it.getName()).isEqualTo(SampleEvent.class.getSimpleName());
4746
assertThat(it.getTag("key")).isNotNull();
4847
});
4948
}

0 commit comments

Comments
 (0)