Improve JdbcChatMemoryRepository to simplify findConversationIds()

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>

Author: quaff

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java

@@ -77,14 +77,7 @@ private JdbcChatMemoryRepository(DataSource dataSource, JdbcChatMemoryRepository
 
 	@Override
 	public List<String> findConversationIds() {
-		List<String> conversationIds = this.jdbcTemplate.query(this.dialect.getSelectConversationIdsSql(), rs -> {
-			var ids = new ArrayList<String>();
-			while (rs.next()) {
-				ids.add(rs.getString(1));
-			}
-			return ids;
-		});
-		return conversationIds != null ? conversationIds : List.of();
+		return this.jdbcTemplate.queryForList(dialect.getSelectConversationIdsSql(), String.class);
 	}
 
 	@Override

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/AbstractJdbcChatMemoryRepositoryIT.java

@@ -73,6 +73,8 @@ void saveMessagesSingleMessage(String content, MessageType messageType) {
 
 		this.chatMemoryRepository.saveAll(conversationId, List.of(message));
 
+		assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
+
 		// Use dialect to get the appropriate SQL query
 		JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect
 			.from(this.jdbcTemplate.getDataSource());
@@ -96,6 +98,8 @@ void saveMessagesMultipleMessages() {
 
 		this.chatMemoryRepository.saveAll(conversationId, messages);
 
+		assertThat(chatMemoryRepository.findConversationIds()).contains(conversationId);
+
 		// Use dialect to get the appropriate SQL query
 		JdbcChatMemoryRepositoryDialect dialect = JdbcChatMemoryRepositoryDialect
 			.from(this.jdbcTemplate.getDataSource());

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryMysqlIT.java

@@ -29,7 +29,8 @@
  * @author Mark Pollack
  */
 @SpringBootTest(classes = JdbcChatMemoryRepositoryMysqlIT.TestConfiguration.class)
-@TestPropertySource(properties = { "spring.datasource.url=jdbc:tc:mariadb:10.3.39:///" })
+@TestPropertySource(properties = { "spring.datasource.url=jdbc:tc:mariadb:10.3.39:///",
+		"spring.datasource.hikari.maximum-pool-size=20", "spring.datasource.hikari.minimum-idle=5" })
 @Sql(scripts = "classpath:org/springframework/ai/chat/memory/repository/jdbc/schema-mariadb.sql")
 class JdbcChatMemoryRepositoryMysqlIT extends AbstractJdbcChatMemoryRepositoryIT {
 

memory/repository/spring-ai-model-chat-memory-repository-jdbc/src/test/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryPostgresqlIT.java

@@ -46,7 +46,8 @@
  * @author Mark Pollack
  */
 @SpringBootTest(classes = JdbcChatMemoryRepositoryPostgresqlIT.TestConfiguration.class)
-@TestPropertySource(properties = "spring.datasource.url=jdbc:tc:postgresql:17:///")
+@TestPropertySource(properties = { "spring.datasource.url=jdbc:tc:postgresql:17:///",
+		"spring.datasource.hikari.maximum-pool-size=20", "spring.datasource.hikari.minimum-idle=5" })
 @Sql(scripts = "classpath:org/springframework/ai/chat/memory/repository/jdbc/schema-postgresql.sql")
 class JdbcChatMemoryRepositoryPostgresqlIT extends AbstractJdbcChatMemoryRepositoryIT {