Fix OpenAiChatClientMethodInvokingFunctionCallbackIT

 - Update test to check if the exception is thrown when using the method without toolcontext as method argument but with explicit toolcontext values

 - Add test to verify that exception is not thrown when toolcontext is not set even with the callback method with the toolcontext argument

Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>

Author: ilayaperumalg

models/spring-ai-openai/src/test/java/org/springframework/ai/openai/chat/client/OpenAiChatClientMethodInvokingFunctionCallbackIT.java

@@ -37,6 +37,7 @@
 import org.springframework.util.ReflectionUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 
 @SpringBootTest(classes = OpenAiTestConfiguration.class)
@@ -165,12 +166,12 @@ void methodGetWeatherToolContext() {
 	}
 
 	@Test
-	void methodGetWeatherToolContextButMissingContextArgument() {
+	void methodGetWeatherNonStaticButWithToolContext() {
 
 		TestFunctionClass targetObject = new TestFunctionClass();
 
-		var toolMethod = ReflectionUtils.findMethod(TestFunctionClass.class, "getWeatherWithContext", String.class,
-				Unit.class, ToolContext.class);
+		var toolMethod = ReflectionUtils.findMethod(TestFunctionClass.class, "getWeatherNonStatic", String.class,
+				Unit.class);
 
 		// @formatter:off
 		assertThatThrownBy(() -> ChatClient.create(this.chatModel).prompt()
@@ -182,13 +183,37 @@ void methodGetWeatherToolContextButMissingContextArgument() {
 					.toolMethod(toolMethod)
 					.toolObject(targetObject)
 					.build())
+				.toolContext(Map.of("tool-context", "value"))
 				.call()
 				.content())
 				.isInstanceOf(IllegalArgumentException.class)
 				.hasMessage("ToolContext is required by the method as an argument");
 		// @formatter:on
 	}
 
+	@Test
+	void methodGetWeatherToolContextButWithoutToolContext() {
+
+		TestFunctionClass targetObject = new TestFunctionClass();
+
+		var toolMethod = ReflectionUtils.findMethod(TestFunctionClass.class, "getWeatherWithContext", String.class,
+				Unit.class, ToolContext.class);
+
+		// @formatter:off
+		assertThatCode(() ->ChatClient.create(this.chatModel).prompt()
+				.user("What's the weather like in San Francisco, Tokyo, and Paris?  Use Celsius.")
+				.toolCallbacks(MethodToolCallback.builder()
+						.toolDefinition(ToolDefinitions.builder(toolMethod)
+								.description("Get the weather in location")
+								.build())
+						.toolMethod(toolMethod)
+						.toolObject(targetObject)
+						.build())
+				.call()
+				.content()).doesNotThrowAnyException();
+		// @formatter:on
+	}
+
 	@Test
 	void methodNoParameters() {