Skip to content

Commit 8053ae3

Browse files
WOONBEilayaperumalg
authored andcommitted
Refactor QdrantObjectFactory to allow null metadata values
Add test for check toObjectMap method allows null metadata values Signed-off-by: WOONBE <kepull2918@naver.com>
1 parent dfa09c1 commit 8053ae3

File tree

2 files changed

+60
-1
lines changed

2 files changed

+60
-1
lines changed

vector-stores/spring-ai-qdrant-store/src/main/java/org/springframework/ai/vectorstore/qdrant/QdrantObjectFactory.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.springframework.ai.vectorstore.qdrant;
1818

19+
import java.util.HashMap;
1920
import java.util.Map;
2021
import java.util.stream.Collectors;
2122

@@ -30,6 +31,7 @@
3031
* Utility methods for building Java objects from io.qdrant.client.grpc.JsonWithInt.Value.
3132
*
3233
* @author Anush Shetty
34+
* @author Heonwoo Kim
3335
* @since 0.8.1
3436
*/
3537
final class QdrantObjectFactory {
@@ -41,7 +43,11 @@ private QdrantObjectFactory() {
4143

4244
public static Map<String, Object> toObjectMap(Map<String, Value> payload) {
4345
Assert.notNull(payload, "Payload map must not be null");
44-
return payload.entrySet().stream().collect(Collectors.toMap(e -> e.getKey(), e -> object(e.getValue())));
46+
Map<String, Object> map = new HashMap<>();
47+
for (Map.Entry<String, Value> entry : payload.entrySet()) {
48+
map.put(entry.getKey(), object(entry.getValue()));
49+
}
50+
return map;
4551
}
4652

4753
private static Object object(ListValue listValue) {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
/*
2+
* Copyright 2023-2024 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.ai.vectorstore.qdrant;
18+
19+
import java.util.Map;
20+
21+
import io.qdrant.client.grpc.JsonWithInt.NullValue;
22+
import io.qdrant.client.grpc.JsonWithInt.Value;
23+
import org.junit.jupiter.api.Test;
24+
25+
import static org.assertj.core.api.Assertions.assertThat;
26+
27+
/**
28+
* Tests for {@link QdrantObjectFactory}.
29+
*
30+
* @author Heonwoo Kim
31+
*/
32+
33+
class QdrantObjectFactoryTests {
34+
35+
@Test
36+
void toObjectMapShouldHandleNullValues() {
37+
Map<String, Value> payloadWithNull = Map.of("name", Value.newBuilder().setStringValue("Spring AI").build(),
38+
"version", Value.newBuilder().setDoubleValue(1.0).build(), "is_ga",
39+
Value.newBuilder().setBoolValue(true).build(), "description",
40+
Value.newBuilder().setNullValue(NullValue.NULL_VALUE).build());
41+
42+
Map<String, Object> result = QdrantObjectFactory.toObjectMap(payloadWithNull);
43+
44+
assertThat(result).isNotNull();
45+
assertThat(result).hasSize(4);
46+
assertThat(result.get("name")).isEqualTo("Spring AI");
47+
assertThat(result.get("version")).isEqualTo(1.0);
48+
assertThat(result.get("is_ga")).isEqualTo(true);
49+
assertThat(result).containsKey("description");
50+
assertThat(result.get("description")).isNull();
51+
}
52+
53+
}

0 commit comments

Comments
 (0)