Skip to content

Commit 5461e83

Browse files
ilayaperumalgmarkpollack
authored andcommitted
Fix Ollam test configuration
- Add missing jackson-module-kotlin for the kotlin tests - Fix Function calling options to use ToolCallingChatOptions Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>
1 parent 989971f commit 5461e83

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

auto-configurations/models/spring-ai-autoconfigure-model-ollama/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@
9696
<artifactId>ollama</artifactId>
9797
<scope>test</scope>
9898
</dependency>
99+
100+
<dependency>
101+
<groupId>com.fasterxml.jackson.module</groupId>
102+
<artifactId>jackson-module-kotlin</artifactId>
103+
<scope>test</scope>
104+
</dependency>
99105
</dependencies>
100106

101107
</project>

auto-configurations/models/spring-ai-autoconfigure-model-ollama/src/test/java/org/springframework/ai/model/ollama/autoconfigure/OllamaChatAutoConfigurationIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ public void chatCompletionWithPull() {
114114

115115
@Test
116116
void chatActivation() {
117-
this.contextRunner.withPropertyValues("spring.ai.ollama.chat.enabled=false").run(context -> {
118-
assertThat(context.getBeansOfType(OllamaChatProperties.class)).isNotEmpty();
117+
this.contextRunner.withPropertyValues("spring.ai.model.chat=none").run(context -> {
118+
assertThat(context.getBeansOfType(OllamaChatProperties.class)).isEmpty();
119119
assertThat(context.getBeansOfType(OllamaChatModel.class)).isEmpty();
120120
});
121121

@@ -124,7 +124,7 @@ void chatActivation() {
124124
assertThat(context.getBeansOfType(OllamaChatModel.class)).isNotEmpty();
125125
});
126126

127-
this.contextRunner.withPropertyValues("spring.ai.ollama.chat.enabled=true").run(context -> {
127+
this.contextRunner.withPropertyValues("spring.ai.model.chat=ollama").run(context -> {
128128
assertThat(context.getBeansOfType(OllamaChatProperties.class)).isNotEmpty();
129129
assertThat(context.getBeansOfType(OllamaChatModel.class)).isNotEmpty();
130130
});

auto-configurations/models/spring-ai-autoconfigure-model-ollama/src/test/java/org/springframework/ai/model/ollama/autoconfigure/OllamaEmbeddingAutoConfigurationIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ public void embeddingWithPull() {
8484

8585
@Test
8686
void embeddingActivation() {
87-
this.contextRunner.withPropertyValues("spring.ai.ollama.embedding.enabled=false").run(context -> {
88-
assertThat(context.getBeansOfType(OllamaEmbeddingProperties.class)).isNotEmpty();
87+
this.contextRunner.withPropertyValues("spring.ai.model.embedding=none").run(context -> {
88+
assertThat(context.getBeansOfType(OllamaEmbeddingProperties.class)).isEmpty();
8989
assertThat(context.getBeansOfType(OllamaEmbeddingModel.class)).isEmpty();
9090
});
9191

auto-configurations/models/spring-ai-autoconfigure-model-ollama/src/test/kotlin/org/springframework/ai/model/ollama/autoconfigure/tool/FunctionCallbackContextKotlinIT.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,11 @@ import org.assertj.core.api.Assertions.assertThat
2020
import org.junit.jupiter.api.BeforeAll
2121
import org.junit.jupiter.api.Test
2222
import org.slf4j.LoggerFactory
23-
24-
import org.springframework.ai.model.ollama.autoconfigure.BaseOllamaIT
25-
import org.springframework.ai.model.ollama.autoconfigure.OllamaChatAutoConfiguration
2623
import org.springframework.ai.chat.messages.UserMessage
2724
import org.springframework.ai.chat.prompt.Prompt
28-
import org.springframework.ai.model.function.FunctionCallingOptions
25+
import org.springframework.ai.model.ollama.autoconfigure.BaseOllamaIT
26+
import org.springframework.ai.model.ollama.autoconfigure.OllamaChatAutoConfiguration
27+
import org.springframework.ai.model.tool.ToolCallingChatOptions
2928
import org.springframework.ai.ollama.OllamaChatModel
3029
import org.springframework.ai.ollama.api.OllamaOptions
3130
import org.springframework.boot.autoconfigure.AutoConfigurations
@@ -87,8 +86,8 @@ class FunctionCallbackResolverKotlinIT : BaseOllamaIT() {
8786
val userMessage = UserMessage(
8887
"What are the weather conditions in San Francisco, Tokyo, and Paris? Find the temperature in Celsius for each of the three locations.")
8988

90-
val functionOptions = FunctionCallingOptions.builder()
91-
.function("weatherInfo")
89+
val functionOptions = ToolCallingChatOptions.builder()
90+
.toolNames("weatherInfo")
9291
.build()
9392

9493
val response = chatModel.call(Prompt(listOf(userMessage), functionOptions));

0 commit comments

Comments
 (0)