diff --git a/.spacelift/config.yml b/.spacelift/config.yml index 481ceef0b..ebdc40f05 100644 --- a/.spacelift/config.yml +++ b/.spacelift/config.yml @@ -1,3 +1,4 @@ version: 1 -module_version: 0.3.3 + +module_version: 0.3.4 diff --git a/main.tf b/main.tf index cfe60d9c7..70fa5d7c4 100644 --- a/main.tf +++ b/main.tf @@ -127,7 +127,7 @@ resource "aws_subnet" "public" { var.public_subnet_names[count.index], format("%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), var.public_subnet_suffix ) ) @@ -269,7 +269,7 @@ resource "aws_subnet" "private" { var.private_subnet_names[count.index], format("%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), var.private_subnet_suffix ) ) @@ -396,7 +396,7 @@ resource "aws_subnet" "database" { format( "%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), var.database_subnet_suffix ) ) @@ -586,7 +586,7 @@ resource "aws_subnet" "redshift" { var.redshift_subnet_names[count.index], format("${var.name_prefix}-${var.short_aws_region}%s-%s-sub-${var.redshift_subnet_suffix}", substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), "") + lookup(local.az_name_to_az_id, element(var.azs, count.index), "") ) ) }, @@ -726,7 +726,7 @@ resource "aws_subnet" "elasticache" { var.elasticache_subnet_names[count.index], format("%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), var.elasticache_subnet_suffix ) ) @@ -859,7 +859,7 @@ resource "aws_subnet" "intra" { var.intra_subnet_names[count.index], format("%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, substr(element(var.azs, count.index), -1, 1), - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), var.intra_subnet_suffix ) ) diff --git a/tgw.tf b/tgw.tf index 6ae7b5244..4c856123a 100644 --- a/tgw.tf +++ b/tgw.tf @@ -1,3 +1,16 @@ +data "aws_availability_zones" "available" { + state = "available" +} + +locals { + az_name_to_az_id = { + for az in data.aws_availability_zones.available.names : az => + split("-", element(data.aws_availability_zones.available.zone_ids, + index(data.aws_availability_zones.available.names, az)) + )[1] + } +} + ################################################################################ # TGW Subnets ################################################################################ @@ -33,8 +46,8 @@ resource "aws_subnet" "tgw" { "%s-%s%s-%s-sub-%s", var.name_prefix, var.short_aws_region, - substr(element(var.azs, count.index), -1, 1), # Get last letter of az code - lookup(var.az_name_to_az_id, element(var.azs, count.index), ""), # Lookup az-id based on name + substr(element(var.azs, count.index), -1, 1), # Get last letter of az code + lookup(local.az_name_to_az_id, element(var.azs, count.index), ""), # Lookup az-id based on name var.tgw_subnet_suffix ) ) diff --git a/variables.tf b/variables.tf index 6fb89a195..e82156f41 100644 --- a/variables.tf +++ b/variables.tf @@ -55,12 +55,6 @@ variable "azs" { default = [] } -variable "az_name_to_az_id" { - description = "A map of availability zones names to ids in the account" - type = map(string) - default = {} -} - variable "enable_dns_hostnames" { description = "Should be true to enable DNS hostnames in the VPC" type = bool