Skip to content

Commit 56a343d

Browse files
committed
Upgrade to Eclipse 2019-03
Closes gh-87
1 parent 61e1a1a commit 56a343d

File tree

4 files changed

+31
-29
lines changed

4 files changed

+31
-29
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<main.basedir>${basedir}</main.basedir>
3232
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
3333
<java.version>1.8</java.version>
34-
<eclipse.repository>https://download.eclipse.org/releases/oxygen/201804111000</eclipse.repository>
34+
<eclipse.repository>https://download.eclipse.org/releases/2019-03/201903201000</eclipse.repository>
3535
<tycho.disableP2Mirrors>true</tycho.disableP2Mirrors>
3636
<ant.version>1.8.1</ant.version>
3737
<ant-contrib.version>1.0b3</ant-contrib.version>

spring-javaformat-eclipse/io.spring.javaformat.eclipse/META-INF/MANIFEST.MF

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Require-Bundle: org.eclipse.ui,
1515
org.eclipse.m2e.core;resolution:=optional,
1616
org.eclipse.m2e.maven.runtime;resolution:=optional,
1717
org.eclipse.buildship.core;resolution:=optional,
18-
com.gradleware.tooling.model;resolution:=optional,
1918
org.slf4j.api;bundle-version="1.7.0"
2019
Bundle-ClassPath: .,
2120
lib/spring-javaformat-formatter-eclipse.jar,

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/gradle/RefreshProjectSettingsListeners.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
package io.spring.javaformat.eclipse.gradle;
1818

19-
import org.eclipse.buildship.core.CorePlugin;
20-
import org.eclipse.buildship.core.event.Event;
21-
import org.eclipse.buildship.core.event.EventListener;
22-
import org.eclipse.buildship.core.workspace.GradleNatureAddedEvent;
23-
import org.eclipse.buildship.core.workspace.ProjectCreatedEvent;
19+
import org.eclipse.buildship.core.internal.CorePlugin;
20+
import org.eclipse.buildship.core.internal.event.Event;
21+
import org.eclipse.buildship.core.internal.event.EventListener;
22+
import org.eclipse.buildship.core.internal.workspace.GradleNatureAddedEvent;
23+
import org.eclipse.buildship.core.internal.workspace.ProjectCreatedEvent;
2424
import org.eclipse.core.commands.Command;
2525
import org.eclipse.core.commands.ExecutionEvent;
2626
import org.eclipse.core.commands.ExecutionException;

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/gradle/RefreshProjectsSettingsJob.java

Lines changed: 25 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@
1919
import java.io.File;
2020
import java.io.IOException;
2121
import java.util.LinkedHashSet;
22+
import java.util.Optional;
2223
import java.util.Set;
2324

24-
import com.google.common.base.Optional;
25-
import com.gradleware.tooling.toolingmodel.OmniEclipseProject;
26-
import com.gradleware.tooling.toolingmodel.OmniProjectTask;
27-
import com.gradleware.tooling.toolingmodel.repository.FetchStrategy;
2825
import io.spring.javaformat.eclipse.Executor;
2926
import io.spring.javaformat.eclipse.Messages;
3027
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFilesLocator;
31-
import org.eclipse.buildship.core.CorePlugin;
32-
import org.eclipse.buildship.core.workspace.GradleBuild;
33-
import org.eclipse.buildship.core.workspace.GradleWorkspaceManager;
28+
import org.eclipse.buildship.core.GradleBuild;
29+
import org.eclipse.buildship.core.internal.CorePlugin;
30+
import org.eclipse.buildship.core.internal.workspace.FetchStrategy;
31+
import org.eclipse.buildship.core.internal.workspace.InternalGradleBuild;
32+
import org.eclipse.buildship.core.internal.workspace.InternalGradleWorkspace;
33+
import org.eclipse.buildship.core.internal.workspace.ModelProviderUtil;
3434
import org.eclipse.core.resources.IProject;
3535
import org.eclipse.core.resources.ResourcesPlugin;
3636
import org.eclipse.core.runtime.CoreException;
@@ -40,6 +40,8 @@
4040
import org.eclipse.core.runtime.jobs.Job;
4141
import org.gradle.tooling.CancellationTokenSource;
4242
import org.gradle.tooling.GradleConnector;
43+
import org.gradle.tooling.model.GradleTask;
44+
import org.gradle.tooling.model.eclipse.EclipseProject;
4345

4446
/**
4547
* Job to trigger refresh of project specific settings when the gradle plugin is used.
@@ -73,30 +75,29 @@ protected IStatus run(IProgressMonitor monitor) {
7375

7476
private void configureProjects(IProgressMonitor monitor)
7577
throws CoreException, IOException {
76-
GradleWorkspaceManager manager = CorePlugin.gradleWorkspaceManager();
78+
InternalGradleWorkspace workspace = CorePlugin.internalGradleWorkspace();
7779
for (IProject project : ResourcesPlugin.getWorkspace().getRoot().getProjects()) {
78-
Optional<GradleBuild> build = manager.getGradleBuild(project);
80+
Optional<GradleBuild> build = workspace.getBuild(project);
7981
if (build.isPresent()) {
80-
configureProject(project, build.get(), monitor);
82+
configureProject(project, (InternalGradleBuild) build.get(), monitor);
8183
}
8284
}
8385
}
8486

85-
private void configureProject(IProject project, GradleBuild build,
87+
private void configureProject(IProject project, InternalGradleBuild build,
8688
IProgressMonitor monitor) throws CoreException, IOException {
87-
Set<OmniEclipseProject> projects = build.getModelProvider()
88-
.fetchEclipseGradleProjects(FetchStrategy.FORCE_RELOAD,
89-
this.tokenSource.token(), monitor);
89+
Set<EclipseProject> projects = ModelProviderUtil.fetchAllEclipseProjects(build,
90+
this.tokenSource, FetchStrategy.FORCE_RELOAD, monitor);
9091
if (hasSpringFormatPlugin(projects)) {
9192
ProjectSettingsFilesLocator locator = new ProjectSettingsFilesLocator(
9293
getSearchFolders(projects));
9394
locator.locateSettingsFiles().applyToProject(project, monitor);
9495
}
9596
}
9697

97-
private boolean hasSpringFormatPlugin(Set<OmniEclipseProject> projects) {
98-
for (OmniEclipseProject project : projects) {
99-
for (OmniProjectTask task : project.getGradleProject().getProjectTasks()) {
98+
private boolean hasSpringFormatPlugin(Set<EclipseProject> projects) {
99+
for (EclipseProject project : projects) {
100+
for (GradleTask task : project.getGradleProject().getTasks()) {
100101
if (isSpringFormatPlugin(task)) {
101102
return true;
102103
}
@@ -105,15 +106,17 @@ private boolean hasSpringFormatPlugin(Set<OmniEclipseProject> projects) {
105106
return false;
106107
}
107108

108-
private boolean isSpringFormatPlugin(OmniProjectTask task) {
109+
private boolean isSpringFormatPlugin(GradleTask task) {
109110
return TASK_NAME.equals(task.getName());
110111
}
111112

112-
private Set<File> getSearchFolders(Set<OmniEclipseProject> projects) {
113+
private Set<File> getSearchFolders(Set<EclipseProject> projects) {
113114
Set<File> searchFolders = new LinkedHashSet<>();
114-
for (OmniEclipseProject project : projects) {
115-
searchFolders.add(project.getProjectDirectory());
116-
searchFolders.add(project.getRoot().getProjectDirectory());
115+
for (EclipseProject project : projects) {
116+
while (project != null) {
117+
searchFolders.add(project.getProjectDirectory());
118+
project = project.getParent();
119+
}
117120
}
118121
return searchFolders;
119122
}

0 commit comments

Comments
 (0)