Skip to content

Commit b874697

Browse files
committed
Enable compiler linting and fix all errors
Closes gh-1653
1 parent e164a25 commit b874697

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

initializr-generator/src/main/java/io/spring/initializr/generator/language/Annotation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ public enum AttributeType {
244244
CLASS() {
245245
@Override
246246
protected Collection<String> getImports(Object value) {
247-
if (value instanceof Class type) {
247+
if (value instanceof Class<?> type) {
248248
return List.of(type.getName());
249249
}
250250
else if (value instanceof ClassName name) {
@@ -260,7 +260,7 @@ else if (value instanceof ClassName name) {
260260
ENUM() {
261261
@Override
262262
protected Collection<String> getImports(Object value) {
263-
if (value instanceof Enum enumeration) {
263+
if (value instanceof Enum<?> enumeration) {
264264
return List.of(enumeration.getClass().getName());
265265
}
266266
return super.getImports(value);
@@ -408,7 +408,7 @@ private CodeBlock generateValueCode(AttributeType attributeType, Object value) {
408408
}
409409
case STRING -> CodeBlock.of("$S", value);
410410
case CLASS -> {
411-
ClassName className = (value instanceof Class clazz) ? ClassName.of(clazz) : (ClassName) value;
411+
ClassName className = (value instanceof Class<?> clazz) ? ClassName.of(clazz) : (ClassName) value;
412412
yield this.formattingOptions.classReference(className);
413413
}
414414
case ENUM -> {

initializr-generator/src/main/java/io/spring/initializr/generator/language/CodeBlock.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ private String argToString(Object arg) {
284284
}
285285

286286
private String argToType(Object arg) {
287-
if (arg instanceof Class type) {
287+
if (arg instanceof Class<?> type) {
288288
this.imports.add(type.getName());
289289
return type.getSimpleName();
290290
}

initializr-generator/src/main/java/io/spring/initializr/generator/version/VersionProperty.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package io.spring.initializr.generator.version;
1818

19+
import java.io.Serial;
1920
import java.io.Serializable;
2021
import java.util.Arrays;
2122
import java.util.List;
@@ -32,6 +33,9 @@
3233
*/
3334
public final class VersionProperty implements Serializable, Comparable<VersionProperty> {
3435

36+
@Serial
37+
private static final long serialVersionUID = 1L;
38+
3539
private static final List<Character> SUPPORTED_CHARS = Arrays.asList('.', '-');
3640

3741
private final String property;

initializr-parent/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,10 @@
183183
<parameters>true</parameters>
184184
<failOnWarning>true</failOnWarning>
185185
<showDeprecation>true</showDeprecation>
186+
<compilerArgs>
187+
<arg>-Xlint:all</arg>
188+
<arg>-Xlint:-processing</arg>
189+
</compilerArgs>
186190
</configuration>
187191
</plugin>
188192
<plugin>

initializr-web/src/main/java/io/spring/initializr/web/autoconfigure/InitializrModule.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package io.spring.initializr.web.autoconfigure;
1818

1919
import java.io.IOException;
20+
import java.io.Serial;
2021

2122
import com.fasterxml.jackson.core.JsonGenerator;
2223
import com.fasterxml.jackson.databind.SerializerProvider;
@@ -31,13 +32,19 @@
3132
*/
3233
class InitializrModule extends SimpleModule {
3334

35+
@Serial
36+
private static final long serialVersionUID = 1L;
37+
3438
InitializrModule() {
3539
super("initializr");
3640
addSerializer(new VersionPropertySerializer());
3741
}
3842

3943
private static class VersionPropertySerializer extends StdSerializer<VersionProperty> {
4044

45+
@Serial
46+
private static final long serialVersionUID = 1L;
47+
4148
VersionPropertySerializer() {
4249
super(VersionProperty.class);
4350
}

0 commit comments

Comments
 (0)