Skip to content

Commit b17cfbd

Browse files
hpoettkermhalbritter
authored andcommitted
Use assignment to set url in Groovy Gradle builds
See gh-1656 Signed-off-by: Henning Pöttker <25299532+hpoettker@users.noreply.github.com>
1 parent afc6301 commit b17cfbd

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

initializr-generator-spring/src/test/resources/project/gradle/repositories-build.gradle.gen

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ java {
1515

1616
repositories {
1717
mavenCentral()
18-
maven { url 'https://example.com/foo' }
19-
maven { url 'https://example.com/bar' }
18+
maven { url = 'https://example.com/foo' }
19+
maven { url = 'https://example.com/bar' }
2020
}
2121

2222
dependencies {

initializr-generator-spring/src/test/resources/project/gradle/repositories-milestone-build.gradle.gen

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ java {
1515

1616
repositories {
1717
mavenCentral()
18-
maven { url 'https://repo.spring.io/milestone' }
18+
maven { url = 'https://repo.spring.io/milestone' }
1919
}
2020

2121
dependencies {

initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ protected String repositoryAsString(MavenRepository repository) {
9292
if (MavenRepository.MAVEN_CENTRAL.equals(repository)) {
9393
return "mavenCentral()";
9494
}
95-
return "maven { url '" + repository.getUrl() + "' }";
95+
return "maven { url = '" + repository.getUrl() + "' }";
9696
}
9797

9898
@Override

initializr-generator/src/main/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleSettingsWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ protected String wrapWithQuotes(String value) {
3030

3131
@Override
3232
protected String urlAssignment(String url) {
33-
return "url " + wrapWithQuotes(url);
33+
return "url = " + wrapWithQuotes(url);
3434
}
3535

3636
}

initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleBuildWriterTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ void gradleBuildWithRepository() {
133133
build.repositories().add(MavenRepository.withIdAndUrl("spring-milestones", "https://repo.spring.io/milestone"));
134134
assertThat(write(build)).contains("""
135135
repositories {
136-
maven { url 'https://repo.spring.io/milestone' }
136+
maven { url = 'https://repo.spring.io/milestone' }
137137
}""");
138138
}
139139

@@ -144,7 +144,7 @@ void gradleBuildWithSnapshotRepository() {
144144
.add(MavenRepository.withIdAndUrl("spring-snapshots", "https://repo.spring.io/snapshot").onlySnapshots());
145145
assertThat(write(build)).contains("""
146146
repositories {
147-
maven { url 'https://repo.spring.io/snapshot' }
147+
maven { url = 'https://repo.spring.io/snapshot' }
148148
}""");
149149
}
150150

initializr-generator/src/test/java/io/spring/initializr/generator/buildsystem/gradle/GroovyDslGradleSettingsWriterTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void gradleBuildWithPluginRepository() {
6363
assertThat(generateSettings(build)).contains("""
6464
pluginManagement {
6565
repositories {
66-
maven { url 'https://repo.spring.io/milestone' }
66+
maven { url = 'https://repo.spring.io/milestone' }
6767
gradlePluginPortal()
6868
}
6969
}""");
@@ -79,7 +79,7 @@ void gradleBuildWithSnapshotPluginRepository() {
7979
assertThat(generateSettings(build)).contains("""
8080
pluginManagement {
8181
repositories {
82-
maven { url 'https://repo.spring.io/snapshot' }
82+
maven { url = 'https://repo.spring.io/snapshot' }
8383
gradlePluginPortal()
8484
}
8585
}""");

0 commit comments

Comments
 (0)