Skip to content

Commit 2cae387

Browse files
committed
Uses new spring.http.client.settings namespace
Fixes gh-3781
1 parent c990c92 commit 2cae387

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

spring-cloud-gateway-server-mvc/src/main/java/org/springframework/cloud/gateway/server/mvc/GatewayServerMvcAutoConfiguration.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
import org.springframework.boot.autoconfigure.AutoConfiguration;
2525
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
27+
import org.springframework.boot.autoconfigure.http.client.AbstractHttpRequestFactoryProperties.Factory;
2728
import org.springframework.boot.autoconfigure.http.client.HttpClientAutoConfiguration;
28-
import org.springframework.boot.autoconfigure.http.client.HttpClientProperties.Factory;
2929
import org.springframework.boot.autoconfigure.web.client.RestClientAutoConfiguration;
3030
import org.springframework.boot.autoconfigure.web.client.RestTemplateAutoConfiguration;
3131
import org.springframework.boot.env.EnvironmentPostProcessor;
32-
import org.springframework.boot.http.client.ClientHttpRequestFactorySettings.Redirects;
32+
import org.springframework.boot.http.client.HttpRedirects;
3333
import org.springframework.boot.web.client.RestClientCustomizer;
3434
import org.springframework.cloud.gateway.server.mvc.common.ArgumentSupplierBeanPostProcessor;
3535
import org.springframework.cloud.gateway.server.mvc.config.GatewayMvcAotRuntimeHintsRegistrar;
@@ -219,14 +219,15 @@ static class GatewayHttpClientEnvironmentPostProcessor implements EnvironmentPos
219219

220220
@Override
221221
public void postProcessEnvironment(ConfigurableEnvironment environment, SpringApplication application) {
222-
Redirects redirects = environment.getProperty("spring.http.client.redirects", Redirects.class);
222+
HttpRedirects redirects = environment.getProperty("spring.http.client.settings.redirects",
223+
HttpRedirects.class);
223224
if (redirects == null) {
224225
// the user hasn't set anything, change the default
225226
environment.getPropertySources()
226227
.addFirst(new MapPropertySource("gatewayHttpClientProperties",
227-
Map.of("spring.http.client.redirects", Redirects.DONT_FOLLOW)));
228+
Map.of("spring.http.client.settings.redirects", HttpRedirects.DONT_FOLLOW)));
228229
}
229-
Factory factory = environment.getProperty("spring.http.client.factory", Factory.class);
230+
Factory factory = environment.getProperty("spring.http.client.settings.factory", Factory.class);
230231
boolean setJdkHttpClientProperties = false;
231232

232233
if (factory == null && !HIGHER_PRIORITY) {

spring-cloud-gateway-server-mvc/src/test/java/org/springframework/cloud/gateway/server/mvc/GatewayServerMvcAutoConfigurationTests.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,23 @@ void bootHttpClientPropertiesWork() {
190190
}
191191

192192
@Test
193-
void settingHttpClientFactoryWorks() {
193+
void settingHttpClientFactoryOldPropertyWorks() {
194194
ConfigurableApplicationContext context = new SpringApplicationBuilder(TestConfig.class)
195195
.properties("spring.main.web-application-type=none", "spring.http.client.factory=simple")
196196
.run();
197197
ClientHttpRequestFactoryBuilder<?> builder = context.getBean(ClientHttpRequestFactoryBuilder.class);
198198
assertThat(builder).isInstanceOf(SimpleClientHttpRequestFactoryBuilder.class);
199199
}
200200

201+
@Test
202+
void settingHttpClientFactoryWorks() {
203+
ConfigurableApplicationContext context = new SpringApplicationBuilder(TestConfig.class)
204+
.properties("spring.main.web-application-type=none", "spring.http.client.settings.factory=simple")
205+
.run();
206+
ClientHttpRequestFactoryBuilder<?> builder = context.getBean(ClientHttpRequestFactoryBuilder.class);
207+
assertThat(builder).isInstanceOf(SimpleClientHttpRequestFactoryBuilder.class);
208+
}
209+
201210
@SpringBootConfiguration
202211
@EnableAutoConfiguration
203212
static class TestConfig {

0 commit comments

Comments
 (0)