Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit ff6d1f2

Browse files
ghillertoodamien
authored andcommitted
gh-614 Fix Lint Errors due to latest Lint upgrade
1 parent dd2eb84 commit ff6d1f2

File tree

81 files changed

+343
-342
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+343
-342
lines changed

ui/src/app/about/about-details.component.html

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ <h2>Data Flow Server Implementation</h2>
77
<table class="table table-hover" id="dataFlowVersionTable">
88
<tbody>
99
<tr>
10-
<td class="col-xs-6">Name</td><td>{{dataflowVersionInfo.versionInfo.implementation.name}}</td>
10+
<td class="col-xs-6">Name</td><td>{{ dataflowVersionInfo.versionInfo.implementation.name }}</td>
1111
</tr>
1212
<tr>
13-
<td class="col-xs-6">Version</td><td>{{dataflowVersionInfo.versionInfo.implementation.version}}</td>
13+
<td class="col-xs-6">Version</td><td>{{ dataflowVersionInfo.versionInfo.implementation.version }}</td>
1414
</tr>
1515
</tbody>
1616
</table>
@@ -84,11 +84,11 @@ <h2>Security Information</h2>
8484
</tr>
8585
<tr>
8686
<td class="col-xs-6">Username</td>
87-
<td id="username">{{dataflowVersionInfo.securityInfo.username || 'N/A'}}</td>
87+
<td id="username">{{ dataflowVersionInfo.securityInfo.username || 'N/A' }}</td>
8888
</tr>
8989
<tr>
9090
<td class="col-xs-6">Roles</td>
91-
<td id="roles">{{dataflowVersionInfo.securityInfo.roles}}</td>
91+
<td id="roles">{{ dataflowVersionInfo.securityInfo.roles }}</td>
9292
</tr>
9393
</tbody>
9494
</table>
@@ -99,24 +99,24 @@ <h2>Version Information</h2>
9999
<tbody>
100100
<tr>
101101
<td class="col-xs-6">Implementation Version</td>
102-
<td>{{dataflowVersionInfo.versionInfo.implementation.version}} ({{dataflowVersionInfo.versionInfo.implementation.name}})</td>
102+
<td>{{ dataflowVersionInfo.versionInfo.implementation.version }} ({{ dataflowVersionInfo.versionInfo.implementation.name }})</td>
103103
</tr>
104104
<tr>
105-
<td class="col-xs-6">Core</td><td>{{dataflowVersionInfo.versionInfo.core.version}} ({{dataflowVersionInfo.versionInfo.core.name}})</td>
105+
<td class="col-xs-6">Core</td><td>{{ dataflowVersionInfo.versionInfo.core.version }} ({{ dataflowVersionInfo.versionInfo.core.name }})</td>
106106
</tr>
107107
<tr>
108-
<td class="col-xs-6">Dashboard</td><td>{{dataflowVersionInfo.versionInfo.dashboard.version}} ({{dataflowVersionInfo.versionInfo.dashboard.name}})</td>
108+
<td class="col-xs-6">Dashboard</td><td>{{ dataflowVersionInfo.versionInfo.dashboard.version }} ({{ dataflowVersionInfo.versionInfo.dashboard.name }})</td>
109109
</tr>
110110
<tr>
111-
<td class="col-xs-6">Shell</td><td>{{dataflowVersionInfo.versionInfo.shell.version}} ({{dataflowVersionInfo.versionInfo.shell.name}})</td>
111+
<td class="col-xs-6">Shell</td><td>{{ dataflowVersionInfo.versionInfo.shell.version }} ({{ dataflowVersionInfo.versionInfo.shell.name }})</td>
112112
</tr>
113113
<tr *ngIf="dataflowVersionInfo.versionInfo.shell.checksumSha1">
114114
<td class="col-xs-6">Shell Checksum Sha1</td>
115-
<td>{{dataflowVersionInfo.versionInfo.shell.checksumSha1}}</td>
115+
<td>{{ dataflowVersionInfo.versionInfo.shell.checksumSha1 }}</td>
116116
</tr>
117117
<tr *ngIf="dataflowVersionInfo.versionInfo.shell.checksumSha256">
118118
<td class="col-xs-6">Shell Checksum Sha256</td>
119-
<td>{{dataflowVersionInfo.versionInfo.shell.checksumSha256}}</td>
119+
<td>{{ dataflowVersionInfo.versionInfo.shell.checksumSha256 }}</td>
120120
</tr>
121121
</tbody>
122122
</table>
@@ -127,34 +127,34 @@ <h2 *ngIf="!dataflowVersionInfo.featureInfo.skipperEnabled">Runtime Environment
127127
<table class="table table-hover" id="appDeployerTable">
128128
<tbody>
129129
<tr>
130-
<td class="col-xs-6">Implementation Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerImplementationVersion}}</td>
130+
<td class="col-xs-6">Implementation Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerImplementationVersion }}</td>
131131
</tr>
132132
<tr>
133-
<td class="col-xs-6">Name</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerName}}</td>
133+
<td class="col-xs-6">Name</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerName }}</td>
134134
</tr>
135135
<tr>
136-
<td class="col-xs-6">Spi Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerSpiVersion}}</td>
136+
<td class="col-xs-6">Spi Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.deployerSpiVersion }}</td>
137137
</tr>
138138
<tr>
139-
<td class="col-xs-6">Java Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.javaVersion}}</td>
139+
<td class="col-xs-6">Java Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.javaVersion }}</td>
140140
</tr>
141141
<tr>
142-
<td class="col-xs-6">Platform Api Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.platformApiVersion}}</td>
142+
<td class="col-xs-6">Platform Api Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.platformApiVersion }}</td>
143143
</tr>
144144
<tr>
145-
<td class="col-xs-6">Platform Client Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.platformClientVersion}}</td>
145+
<td class="col-xs-6">Platform Client Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.platformClientVersion }}</td>
146146
</tr>
147147
<tr>
148-
<td class="col-xs-6">Platform Host Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.platformHostVersion}}</td>
148+
<td class="col-xs-6">Platform Host Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.platformHostVersion }}</td>
149149
</tr>
150150
<tr>
151-
<td class="col-xs-6">Platform Type</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.platformType}}</td>
151+
<td class="col-xs-6">Platform Type</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.platformType }}</td>
152152
</tr>
153153
<tr>
154-
<td class="col-xs-6">Spring Boot Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.springBootVersion}}</td>
154+
<td class="col-xs-6">Spring Boot Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.springBootVersion }}</td>
155155
</tr>
156156
<tr>
157-
<td class="col-xs-6">Spring Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.appDeployer.springVersion}}</td>
157+
<td class="col-xs-6">Spring Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.appDeployer.springVersion }}</td>
158158
</tr>
159159
</tbody>
160160
</table>
@@ -167,7 +167,7 @@ <h2 *ngIf="!dataflowVersionInfo.featureInfo.skipperEnabled">Platform-specific In
167167
<ng-template *ngIf="dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo && dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo.size > 0"
168168
ngFor let-item [ngForOf]="dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo | mapValuesPipe">
169169
<tr>
170-
<td class="col-xs-6">{{item.key}}</td><td>{{item.value}}</td>
170+
<td class="col-xs-6">{{ item.key }}</td><td>{{ item.value }}</td>
171171
</tr>
172172
</ng-template>
173173
<tr *ngIf="!dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo || dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo.size == 0">
@@ -183,34 +183,34 @@ <h2>Runtime Environment - Task Launcher</h2>
183183
<table class="table table-hover" *ngIf="!isEmpty(dataflowVersionInfo.runtimeEnvironment.taskLauncher)" id="taskLauncherTable">
184184
<tbody>
185185
<tr>
186-
<td class="col-xs-6">Implementation Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerImplementationVersion}}</td>
186+
<td class="col-xs-6">Implementation Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerImplementationVersion }}</td>
187187
</tr>
188188
<tr>
189-
<td class="col-xs-6">Name</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerName}}</td>
189+
<td class="col-xs-6">Name</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerName }}</td>
190190
</tr>
191191
<tr>
192-
<td class="col-xs-6">Spi Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerSpiVersion}}</td>
192+
<td class="col-xs-6">Spi Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.deployerSpiVersion }}</td>
193193
</tr>
194194
<tr>
195-
<td class="col-xs-6">Java Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.javaVersion}}</td>
195+
<td class="col-xs-6">Java Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.javaVersion }}</td>
196196
</tr>
197197
<tr>
198-
<td class="col-xs-6">Platform Api Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformApiVersion}}</td>
198+
<td class="col-xs-6">Platform Api Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformApiVersion }}</td>
199199
</tr>
200200
<tr>
201-
<td class="col-xs-6">Platform Client Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformClientVersion}}</td>
201+
<td class="col-xs-6">Platform Client Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformClientVersion }}</td>
202202
</tr>
203203
<tr>
204-
<td class="col-xs-6">Platform Host Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformHostVersion}}</td>
204+
<td class="col-xs-6">Platform Host Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformHostVersion }}</td>
205205
</tr>
206206
<tr>
207-
<td class="col-xs-6">Platform Type</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformType}}</td>
207+
<td class="col-xs-6">Platform Type</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformType }}</td>
208208
</tr>
209209
<tr>
210-
<td class="col-xs-6">Spring Boot Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.springBootVersion}}</td>
210+
<td class="col-xs-6">Spring Boot Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.springBootVersion }}</td>
211211
</tr>
212212
<tr>
213-
<td class="col-xs-6">Spring Version</td><td>{{dataflowVersionInfo.runtimeEnvironment.taskLauncher.springVersion}}</td>
213+
<td class="col-xs-6">Spring Version</td><td>{{ dataflowVersionInfo.runtimeEnvironment.taskLauncher.springVersion }}</td>
214214
</tr>
215215
</tbody>
216216
</table>
@@ -222,7 +222,7 @@ <h2>Platform-specific Information of the Task Launcher</h2>
222222
<ng-template *ngIf="dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformSpecificInfo && dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformSpecificInfo.size > 0"
223223
ngFor let-item [ngForOf]="dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformSpecificInfo | mapValuesPipe">
224224
<tr>
225-
<td class="col-xs-6">{{item.key}}</td><td>{{item.value}}</td>
225+
<td class="col-xs-6">{{ item.key }}</td><td>{{ item.value }}</td>
226226
</tr>
227227
</ng-template>
228228
<tr *ngIf="!dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformSpecificInfo || dataflowVersionInfo.runtimeEnvironment.taskLauncher.platformSpecificInfo.size == 0">

ui/src/app/about/about.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ <h2>Data Flow Server Implementation</h2>
1111
<table id="dataFlowVersionTable" class="table table-hover">
1212
<tbody>
1313
<tr>
14-
<td>Name</td><td>{{dataflowVersionInfo ? dataflowVersionInfo.versionInfo.implementation.name : 'N/A'}}</td>
14+
<td>Name</td><td>{{ dataflowVersionInfo ? dataflowVersionInfo.versionInfo.implementation.name : 'N/A' }}</td>
1515
</tr>
1616
<tr>
17-
<td>Version</td><td>{{dataflowVersionInfo ? dataflowVersionInfo.versionInfo.implementation.version : 'N/A'}}</td>
17+
<td>Version</td><td>{{ dataflowVersionInfo ? dataflowVersionInfo.versionInfo.implementation.version : 'N/A' }}</td>
1818
</tr>
1919
</tbody>
2020
</table>
@@ -28,8 +28,8 @@ <h2>Data Flow Server Implementation</h2>
2828
<h2 style="margin-top: 1em;" *ngIf="dataflowVersionInfo">Get the Spring Cloud Data Flow Shell</h2>
2929

3030
<p class="index-page--subtitle">As an alternative to the Dashboard UI, you can also
31-
<a href="{{dataflowVersionInfo.versionInfo.shell.url}}"
32-
target="_blank">download the compatible version of the Shell</a> ({{dataflowVersionInfo.versionInfo.shell.version}}).</p>
31+
<a href="{{ dataflowVersionInfo.versionInfo.shell.url }}"
32+
target="_blank">download the compatible version of the Shell</a> ({{ dataflowVersionInfo.versionInfo.shell.version }}).</p>
3333

3434
<h2>Need Help or Found an Issue?</h2>
3535

@@ -42,10 +42,10 @@ <h2>Need Help or Found an Issue?</h2>
4242
<td>Sources</td><td><a target="_blank" href="https://github.com/spring-cloud/spring-cloud-dataflow">https://github.com/spring-cloud/spring-cloud-dataflow</a></td>
4343
</tr>
4444
<tr>
45-
<td>Documentation</td><td><a target="_blank" href="http://docs.spring.io/spring-cloud-dataflow/docs/{{dataflowVersionInfo.versionInfo.core.version}}/reference/htmlsingle/">http://docs.spring.io/spring-cloud-dataflow/docs/{{dataflowVersionInfo.versionInfo.core.version}}/reference/htmlsingle/</a></td>
45+
<td>Documentation</td><td><a target="_blank" href="http://docs.spring.io/spring-cloud-dataflow/docs/{{ dataflowVersionInfo.versionInfo.core.version }}/reference/htmlsingle/">http://docs.spring.io/spring-cloud-dataflow/docs/{{ dataflowVersionInfo.versionInfo.core.version }}/reference/htmlsingle/</a></td>
4646
</tr>
4747
<tr>
48-
<td>API Docs</td><td><a target="_blank" href="http://docs.spring.io/spring-cloud-dataflow/docs/{{dataflowVersionInfo.versionInfo.core.version}}/api/">http://docs.spring.io/spring-cloud-dataflow/docs/{{dataflowVersionInfo.versionInfo.core.version}}/api/</a></td>
48+
<td>API Docs</td><td><a target="_blank" href="http://docs.spring.io/spring-cloud-dataflow/docs/{{ dataflowVersionInfo.versionInfo.core.version }}/api/">http://docs.spring.io/spring-cloud-dataflow/docs/{{ dataflowVersionInfo.versionInfo.core.version }}/api/</a></td>
4949
</tr>
5050
<tr>
5151
<td>Support Forum</td><td><a target="_blank" href="http://stackoverflow.com/questions/tagged/spring-cloud-dataflow">http://stackoverflow.com/questions/tagged/spring-cloud-dataflow</a></td>

ui/src/app/analytics/charts/pie-chart/pie-chart.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export class PieChartComponent implements OnInit, OnChanges {
235235
.attr('d', path)
236236
.attr('fill', function(d, i) { return colors[i]; });
237237

238-
slice.on('mousemove', function(d){
238+
slice.on('mousemove', function(d) {
239239
console.log('mouse move');
240240
// div.style('left', d3.event.pageX+10+'px');
241241
// div.style('top', d3.event.pageY-25+'px');

ui/src/app/analytics/components/counter-header.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import { Counter } from '../model/counter.model';
99
@Component({
1010
selector: 'app-counter-header',
1111
template: `
12-
<h2>Value: {{counter.value}} | Latest Rate:
13-
{{counter.rates && counter.rates.length ? counter.rates[counter.rates.length - 1] + " counts/second" : "--N/A--"}}</h2>
12+
<h2>Value: {{ counter.value }} | Latest Rate:
13+
{{ counter.rates && counter.rates.length ? counter.rates[counter.rates.length - 1] + " counts/second" : "--N/A--" }}</h2>
1414
`
1515
})
1616
export class CounterHeaderComponent {

ui/src/app/analytics/counters/counters.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
</thead>
2121
<tbody>
2222
<tr *ngFor="let item of counters.items | paginate: counters.getPaginationInstance(); index as i; trackBy: trackByIndex">
23-
<td>{{item.name}}</td>
24-
<td>{{item.value}}</td>
25-
<td>{{item.latestRate}}</td>
23+
<td>{{ item.name }}</td>
24+
<td>{{ item.value }}</td>
25+
<td>{{ item.latestRate }}</td>
2626
<td>
2727
<app-graph-chart [chartData]="item.rates" [height]="140" [total]="totalCacheSize()"
2828
[reverse]="true" [axisUnitsX]="'seconds ago'" [axisUnitsY]="'counts'"

0 commit comments

Comments
 (0)