sync node refactored into SYNC to match the server side

- Fixes #524

Author: BoykoAlex

ui/src/app/tasks/flo/node/node.component.html

@@ -17,7 +17,7 @@
     <svg:circle class="input-port" tooltip="Input Port" container="body" [isDisabled]="!isCanvas() && canvasNodeTooltip"/>
   </svg:g>
 
-  <svg:g *ngSwitchCase="'sync'" class="composed-task">
+  <svg:g *ngSwitchCase="'SYNC'" class="composed-task">
     <svg:g class="shape" [tooltip]="canvasNodeTooltip" container="body" placement="bottom" containerClass="app-tooltip" [isDisabled]="isDisabled">
       <svg:circle class="border"/>
       <svg:text class="label"/>

ui/src/app/tasks/flo/render.service.ts

@@ -6,7 +6,7 @@ import { BsModalService } from 'ngx-bootstrap';
 import { MetamodelService} from './metamodel.service';
 import {
   TaskAppShape, BatchSyncShape, BatchLink, BatchStartShape, BatchEndShape,
-  CONTROL_GROUP_TYPE, IMAGE_W
+  CONTROL_GROUP_TYPE, IMAGE_W, START_NODE_TYPE, END_NODE_TYPE, SYNC_NODE_TYPE
 } from './support/shapes';
 import { layout } from './support/layout';
 import { ElementComponent } from '../../shared/flo/support/shape-component';
@@ -96,46 +96,47 @@ export class RenderService implements Flo.Renderer {
    * @returns {dia.Element} the created element
    */
   createNode(metadata: Flo.ElementMetadata): dia.Element {
-    if (metadata.name === 'START') {
-      return new BatchStartShape(
-        defaultsDeep({
-          attrs: {
-            '.label': {
-              'text': metadata.name
+    switch (metadata.name) {
+      case START_NODE_TYPE:
+        return new BatchStartShape(
+          defaultsDeep({
+            attrs: {
+              '.label': {
+                'text': metadata.name
+              }
             }
-          }
-        }, BatchStartShape.prototype.defaults)
-      );
-    } else if (metadata.name === 'END') {
-      return new BatchEndShape(
-        defaultsDeep({
-          attrs: {
-            '.label': {
-              'text': metadata.name
+          }, BatchStartShape.prototype.defaults)
+        );
+      case END_NODE_TYPE:
+        return new BatchEndShape(
+          defaultsDeep({
+            attrs: {
+              '.label': {
+                'text': metadata.name
+              }
             }
-          }
-        }, BatchEndShape.prototype.defaults)
-      );
-    } else if (metadata.name === 'sync') {
-      return new BatchSyncShape(
-        defaultsDeep({
-          attrs: {
-            '.label': {
-              'text': metadata.name
+          }, BatchEndShape.prototype.defaults)
+        );
+      case SYNC_NODE_TYPE:
+        return new BatchSyncShape(
+          defaultsDeep({
+            attrs: {
+              '.label': {
+                'text': metadata.name
+              }
             }
-          }
-        }, BatchSyncShape.prototype.defaults)
-      );
-    } else {
-      return new TaskAppShape(
-        defaultsDeep({
-          attrs: {
-            '.label': {
-              'text': metadata.name
+          }, BatchSyncShape.prototype.defaults)
+        );
+      default:
+        return new TaskAppShape(
+          defaultsDeep({
+            attrs: {
+              '.label': {
+                'text': metadata.name
+              }
             }
-          }
-        }, TaskAppShape.prototype.defaults)
-      );
+          }, TaskAppShape.prototype.defaults)
+        );
     }
   }
 

ui/src/app/tasks/flo/support/shapes.ts

@@ -10,7 +10,7 @@ export const TASK_GROUP_TYPE = 'task';
 
 export const START_NODE_TYPE = 'START';
 export const END_NODE_TYPE = 'END';
-export const SYNC_NODE_TYPE = 'sync';
+export const SYNC_NODE_TYPE = 'SYNC';
 
 const CONTROL_NODE_SIZE = {
   width: 40,