Task Launch: fix properties concatenation

Resolves #915
- Fix concatenation properties
- Add tests

Author: oodamien

ui/src/app/tasks/task-launch/task-launch.component.spec.ts

@@ -82,4 +82,34 @@ describe('TaskLaunchComponent', () => {
     expect(component).toBeTruthy();
   });
 
+
+  describe('Prepare Arguments', () => {
+
+    beforeEach(() => {
+      fixture.detectChanges();
+    });
+
+    it('Name, no arg, 2 properties', () => {
+      const result = component.prepareParams('name', [], ['prop1=val1', 'prop2=val2']);
+      expect(result.name).toBe('name');
+      expect(result.args).toBe('');
+      expect(result.props).toBe('prop1=val1, prop2=val2');
+    });
+
+    it('Name, 2 args, no property', () => {
+      const result = component.prepareParams('name', ['arg1=val1', 'arg2=val2'], []);
+      expect(result.name).toBe('name');
+      expect(result.args).toBe('arg1=val1 arg2=val2');
+      expect(result.props).toBe('');
+    });
+
+    it('Name, 2 args, 2 properties', () => {
+      const result = component.prepareParams('name', ['arg1=valArg1', 'arg2=valArg2'], ['prop1=valProp1', 'prop2=valProp2']);
+      expect(result.name).toBe('name');
+      expect(result.args).toBe('arg1=valArg1 arg2=valArg2');
+      expect(result.props).toBe('prop1=valProp1, prop2=valProp2');
+    });
+
+  });
+
 });

ui/src/app/tasks/task-launch/task-launch.component.ts

@@ -11,6 +11,7 @@ import { TaskLaunchValidator } from './task-launch.validator';
 import { NotificationService } from '../../shared/services/notification.service';
 import { AppError } from '../../shared/model/error.model';
 import { RoutingStateService } from '../../shared/services/routing-state.service';
+import { TaskLaunchParams } from '../components/tasks.interface';
 
 /**
  * Component that provides a launcher of task.
@@ -109,6 +110,21 @@ export class TaskLaunchComponent implements OnInit, OnDestroy {
     this.ngUnsubscribe$.complete();
   }
 
+  /**
+   * Prepare params
+   * @param {string} name
+   * @param {Array<string>} taskArguments
+   * @param {Array<string>} taskProperties
+   * @returns {TaskLaunchParams}
+   */
+  prepareParams(name: string, taskArguments: Array<string>, taskProperties: Array<string>): TaskLaunchParams {
+    return {
+      name: name,
+      args: taskArguments.join(' '),
+      props: taskProperties.join(', ')
+    };
+  }
+
   /**
    * Launch the task
    *
@@ -125,11 +141,8 @@ export class TaskLaunchComponent implements OnInit, OnDestroy {
     };
     const taskArguments = getClean(this.form.get('args') as FormArray);
     const taskProperties = getClean(this.form.get('params') as FormArray);
-    const busy = this.tasksService.launchDefinition({
-      name: name,
-      args: taskArguments.join(' '),
-      props: taskProperties.join(',')
-    }).pipe(takeUntil(this.ngUnsubscribe$))
+    const busy = this.tasksService.launchDefinition(this.prepareParams(name, taskArguments, taskProperties))
+      .pipe(takeUntil(this.ngUnsubscribe$))
       .subscribe(
         data => {
           this.notificationService.success('Successfully launched task "' + name + '"');