Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 6d0f9bd

Browse files
oodamienghillert
authored andcommitted
gh-1217 Delete Task Executions
- Task Executions list: add bulk delete action and delete action - Task Execution: add delete action - Task Definition - Executions list: add bulk delete action and delete action - Add Task Executions Destroy modal - Update model TaskExecution: add parentTaskExecutionId - Update checkbox master: null as an no item - Task execution with parentTaskExecutionId can not be destroyed Resolves #1217
1 parent 71f5856 commit 6d0f9bd

33 files changed

+786
-62
lines changed

ui/src/app/apps/app-details/app-details.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export class AppDetailsComponent implements OnInit, OnDestroy {
111111
}
112112

113113
/**
114-
* Will cleanup any {@link Subscription}s to prevent
114+
* Will clean up any {@link Subscription}s to prevent
115115
* memory leaks.
116116
*/
117117
ngOnDestroy() {

ui/src/app/apps/apps-add/properties/apps-bulk-import-properties.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class AppsBulkImportPropertiesComponent implements OnDestroy {
6060
}
6161

6262
/**
63-
* Will cleanup any {@link Subscription}s to prevent
63+
* Will clean up any {@link Subscription}s to prevent
6464
* memory leaks.
6565
*/
6666
ngOnDestroy() {

ui/src/app/apps/apps-add/register/apps-register.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class AppsRegisterComponent implements OnInit, OnDestroy {
6767
}
6868

6969
/**
70-
* Will cleanup any {@link Subscription}s to prevent
70+
* Will clean up any {@link Subscription}s to prevent
7171
* memory leaks.
7272
*/
7373
ngOnDestroy() {

ui/src/app/apps/apps-add/uri/apps-bulk-import-uri.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class AppsBulkImportUriComponent implements OnDestroy {
5959
}
6060

6161
/**
62-
* Will cleanup any {@link Subscription}s to prevent
62+
* Will clean up any {@link Subscription}s to prevent
6363
* memory leaks.
6464
*/
6565
ngOnDestroy() {

ui/src/app/audit/audit-record-details/audit-record-details.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class AuditRecordDetailsComponent implements OnInit, OnDestroy {
6262
}
6363

6464
/**
65-
* Will cleanup any {@link Subscription}s to prevent
65+
* Will clean up any {@link Subscription}s to prevent
6666
* memory leaks.
6767
*/
6868
ngOnDestroy() {

ui/src/app/auth/logout.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class LogoutComponent implements OnInit, OnDestroy {
5555
}
5656

5757
/**
58-
* Will cleanup any {@link Subscription}s to prevent
58+
* Will clean up any {@link Subscription}s to prevent
5959
* memory leaks.
6060
*/
6161
ngOnDestroy() {

ui/src/app/jobs/jobs/jobs.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class JobsComponent implements OnInit, OnDestroy {
9494
}
9595

9696
/**
97-
* Will cleanup any {@link Subscription}s to prevent
97+
* Will clean up any {@link Subscription}s to prevent
9898
* memory leaks.
9999
*/
100100
ngOnDestroy() {

ui/src/app/layout/navigation/navigation.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class NavigationComponent implements DoCheck, OnInit, OnDestroy {
5959
}
6060

6161
/**
62-
* Will cleanup any {@link Subscription}s to prevent
62+
* Will clean up any {@link Subscription}s to prevent
6363
* memory leaks.
6464
*/
6565
ngOnDestroy() {

ui/src/app/shared/components/master-checkbox.component.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,22 @@ export class MasterCheckboxComponent implements DoCheck, AfterViewInit {
4040
if (!this.items) {
4141
return;
4242
}
43-
const count = this.items.reduce((a, b) => b ? a + 1 : a, 0);
44-
const indeterminate = (count > 0 && count < this.items.length);
43+
const filtered = this.items.filter(i => i !== null);
44+
const count = filtered.reduce((a, b) => b ? a + 1 : a, 0);
45+
const indeterminate = (count > 0 && count < filtered.length);
4546
if ((count > 0) === this.input && this.checkbox.nativeElement.indeterminate === indeterminate) {
4647
return;
4748
}
48-
4949
this.input = (count > 0);
5050
this.checkbox.nativeElement.indeterminate = indeterminate;
5151
this.change.emit({value: (count > 0), indeterminate: indeterminate});
5252
}
5353

5454
click() {
5555
for (let i = 0; i < this.items.length; i++) {
56-
this.items[i] = this.input;
56+
if (this.items[i] !== null) {
57+
this.items[i] = this.input;
58+
}
5759
}
5860
}
5961

ui/src/app/streams/stream-create/create-dialog/create-dialog.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export class StreamCreateDialogComponent extends Modal implements OnInit, OnDest
127127
}
128128

129129
/**
130-
* Will cleanup any {@link Subscription}s to prevent
130+
* Will clean up any {@link Subscription}s to prevent
131131
* memory leaks.
132132
*/
133133
ngOnDestroy() {

0 commit comments

Comments
 (0)