Stream Creation: deploy option conditional show

The deploy option is not available if skipper is enabled and more than one platform available
Resolves #783

Author: oodamien

ui/src/app/streams/stream-create/create-dialog/create-dialog.component.html

@@ -49,7 +49,7 @@ <h4 class="modal-title pull-left">Create Stream</h4>
           </div>
         </div>
       </div>
-      <div class="row row-stream-deploy">
+      <div class="row row-stream-deploy" *ngIf="isDeployEnabled">
         <div class="col-sm-offset-4 col-sm-18">
           <label class="checkbox-inline">
             <input [disabled]="isStreamCreationInProgress()" type="checkbox" [(ngModel)]="deploy"

ui/src/app/streams/stream-create/create-dialog/create-dialog.component.spec.ts

@@ -0,0 +1,121 @@
+import { StreamCreateDialogComponent } from './create-dialog.component';
+import { NgBusyModule } from 'ng-busy';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { MockStreamsService } from '../../../tests/mocks/streams';
+import { RouterTestingModule } from '@angular/router/testing';
+import { StreamsService } from '../../streams.service';
+import { FloModule } from 'spring-flo';
+import { BsModalRef, ModalModule } from 'ngx-bootstrap';
+import { ParserService } from '../../../shared/services/parser.service';
+import { BusyService } from '../../../shared/services/busy.service';
+import { LoggerService } from '../../../shared/services/logger.service';
+import { MockNotificationService } from '../../../tests/mocks/notification';
+import { NotificationService } from '../../../shared/services/notification.service';
+import { SharedAboutService } from '../../../shared/services/shared-about.service';
+import { MocksSharedAboutService } from '../../../tests/mocks/shared-about';
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
+import { SharedModule } from '../../../shared/shared.module';
+import { By } from '@angular/platform-browser';
+import { Observable } from 'rxjs/Observable';
+import { FeatureInfo } from '../../../shared/model/about/feature-info.model';
+import { Platform } from '../../model/platform';
+
+/**
+ * Test {@link StreamCreateDialogComponent}.
+ *
+ * @author Alex Boyko
+ */
+describe('StreamCreateDialogComponent', () => {
+  let component: StreamCreateDialogComponent;
+  let fixture: ComponentFixture<StreamCreateDialogComponent>;
+  const streamsService = new MockStreamsService();
+  const busyService = new BusyService();
+  const loggerService = new LoggerService();
+  const parserService = new ParserService();
+  const notificationService = new MockNotificationService();
+  const aboutService = new MocksSharedAboutService();
+
+
+  beforeEach(async () => {
+    TestBed.configureTestingModule({
+      declarations: [
+        StreamCreateDialogComponent
+      ],
+      imports: [
+        RouterTestingModule.withRoutes([]),
+        SharedModule,
+        FormsModule,
+        ReactiveFormsModule,
+        ModalModule,
+        FloModule,
+        NgBusyModule,
+        NoopAnimationsModule
+      ],
+      providers: [
+        { provide: StreamsService, useValue: streamsService },
+        { provide: BusyService, useValue: busyService },
+        { provide: ParserService, useValue: parserService },
+        { provide: LoggerService, useValue: loggerService },
+        { provide: NotificationService, useValue: notificationService },
+        { provide: SharedAboutService, useValue: aboutService },
+        { provide: BsModalRef, useValue: null },
+      ]
+    })
+      .compileComponents();
+  });
+
+  beforeEach(() => {
+    fixture = TestBed.createComponent(StreamCreateDialogComponent);
+    component = fixture.componentInstance;
+  });
+
+  it('should be created', () => {
+    fixture.detectChanges();
+    expect(component).toBeTruthy();
+  });
+
+  it('default mocks: single deployment platform (skipper mode off, multiple platforms)', () => {
+    fixture.detectChanges();
+    const deployDiv = fixture.debugElement.query(By.css('.row .row-stream-deploy'));
+    expect(deployDiv).toBeDefined();
+  });
+
+  it('skipper mode and multiple platforms => deploy checkbox is hidden', () => {
+    const featureInfo = new FeatureInfo();
+    featureInfo.skipperEnabled = true;
+    spyOn(aboutService, 'getFeatureInfo').and.returnValue(Observable.of(featureInfo));
+    fixture.detectChanges();
+    const deployDiv = fixture.debugElement.query(By.css('.row .row-stream-deploy'));
+    expect(deployDiv).toBeFalsy();
+  });
+
+  it('skipper mode on and single platform => deploy checkbox is shown', () => {
+    const featureInfo = new FeatureInfo();
+    featureInfo.skipperEnabled = true;
+    spyOn(aboutService, 'getFeatureInfo').and.returnValue(Observable.of(featureInfo));
+    spyOn(streamsService, 'platforms').and.returnValue(Observable.of([
+      new Platform('default', 'local')
+    ]));
+    fixture.detectChanges();
+    const deployDiv = fixture.debugElement.query(By.css('.row .row-stream-deploy'));
+    expect(deployDiv).toBeDefined();
+  });
+
+  // it('skipper mode errors out => deploy checkbox is hidden', () => {
+  //   const featureInfo = new FeatureInfo();
+  //   featureInfo.skipperEnabled = true;
+  //   spyOn(aboutService, 'getFeatureInfo').and.returnValue(Observable.throw('Error'));
+  //   fixture.detectChanges();
+  //   const deployDiv = fixture.debugElement.query(By.css('.row .row-stream-deploy'));
+  //   expect(deployDiv).toBeFalsy();
+  // });
+
+  it('platforms() call errors out => deploy checkbox is hidden', () => {
+    spyOn(streamsService, 'platforms').and.returnValue(Observable.throw('Error'));
+    fixture.detectChanges();
+    const deployDiv = fixture.debugElement.query(By.css('.row .row-stream-deploy'));
+    expect(deployDiv).toBeFalsy();
+  });
+
+});

ui/src/app/streams/stream-create/create-dialog/create-dialog.component.ts

@@ -11,12 +11,13 @@ import { Router } from '@angular/router';
 import { SharedAboutService } from '../../../shared/services/shared-about.service';
 import { FeatureInfo } from '../../../shared/model/about/feature-info.model';
 import { Observable } from 'rxjs/Observable';
-import { share, takeUntil } from 'rxjs/operators';
+import { mergeMap, share, takeUntil } from 'rxjs/operators';
 import { Subject } from 'rxjs/Subject';
 import { Modal } from '../../../shared/components/modal/modal-abstract';
 import { BusyService } from '../../../shared/services/busy.service';
 import { NotificationService } from '../../../shared/services/notification.service';
 import { LoggerService } from '../../../shared/services/logger.service';
+import { Platform } from '../../model/platform';
 
 /**
  * Stores progress percentage.
@@ -69,6 +70,11 @@ export class StreamCreateDialogComponent extends Modal implements OnInit, OnDest
    */
   streamDefs: Array<any> = [];
 
+  /**
+   * Is deploy option enabled
+   */
+  isDeployEnabled = false;
+
   /**
    * Errors
    */
@@ -94,8 +100,15 @@ export class StreamCreateDialogComponent extends Modal implements OnInit, OnDest
    */
   confirm: EventEmitter<boolean> = new EventEmitter();
 
+  /**
+   * FeatureInfo Observable
+   */
+  featureInfo$: Observable<FeatureInfo>;
 
-  featureInfo: Observable<FeatureInfo>;
+  /**
+   * FeatureInfo Subscription
+   */
+  featureInfoSubscription: Subscription;
 
   /**
    * Constructor
@@ -125,7 +138,20 @@ export class StreamCreateDialogComponent extends Modal implements OnInit, OnDest
    */
   ngOnInit() {
     this.form = new FormGroup({}, this.uniqueStreamNames());
-    this.featureInfo = this.aboutService.getFeatureInfo().pipe(share());
+    this.featureInfo$ = this.aboutService.getFeatureInfo()
+      .pipe(mergeMap(
+        (featureInfo: FeatureInfo) => {
+          return featureInfo.skipperEnabled ? this.streamService.platforms() : Observable.of([]);
+        },
+        (featureInfo: FeatureInfo, platforms: Platform[]) => {
+          if (platforms.length < 2) {
+            this.isDeployEnabled = true;
+          }
+          return featureInfo;
+        }))
+      .pipe(share());
+
+    this.featureInfoSubscription = this.featureInfo$.subscribe();
   }
 
   /**
@@ -145,6 +171,7 @@ export class StreamCreateDialogComponent extends Modal implements OnInit, OnDest
   ngOnDestroy() {
     this.ngUnsubscribe$.next();
     this.ngUnsubscribe$.complete();
+    this.featureInfoSubscription.unsubscribe();
   }
 
   /**