gh-581 List skipper feature-toggle info in the about tab

Author: ghillert

ui/src/app/about/about-details.component.html

@@ -40,6 +40,13 @@ <h2>Enabled Features</h2>
       <span *ngIf="!dataflowVersionInfo.featureInfo.tasksEnabled" class="glyphicon glyphicon-remove text-danger" aria-label="false" id="tasksDisabled"></span>
     </td>
   </tr>
+  <tr>
+    <td class="col-xs-6">Skipper Mode</td>
+    <td>
+      <span *ngIf="dataflowVersionInfo.featureInfo.skipperEnabled" class="glyphicon glyphicon-ok text-success" aria-label="true" id="skipperEnabled"></span>
+      <span *ngIf="!dataflowVersionInfo.featureInfo.skipperEnabled" class="glyphicon glyphicon-remove text-danger" aria-label="false" id="skipperDisabled"></span>
+    </td>
+  </tr>
   </tbody>
 </table>
 

ui/src/app/about/about-details.component.spec.ts

@@ -58,8 +58,8 @@ describe('AboutDetailsComponent', () => {
     validateColumnValues('dataFlowVersionTable', ['FOO', 'BAR'], 1);
 
     // Verify Enabled Features
-    validateColumnValues('enabledFeaturesTable', ['Analytics', 'Streams', 'Tasks'], 0);
-    validateSpansExists(['analyticsEnabled', 'streamsEnabled', 'streamsEnabled']);
+    validateColumnValues('enabledFeaturesTable', ['Analytics', 'Streams', 'Tasks', 'Skipper Mode'], 0);
+    validateSpansExists(['analyticsEnabled', 'streamsEnabled', 'tasksEnabled', 'skipperEnabled']);
 
     // Verify Security Information
     validateColumnValues('securityInformationTable', ['Authentication', 'Authorization',
@@ -105,8 +105,8 @@ describe('AboutDetailsComponent', () => {
     expect(component).toBeTruthy();
 
     // Verify Enabled Features
-    validateColumnValues('enabledFeaturesTable', ['Analytics', 'Streams', 'Tasks'], 0);
-    validateSpansExists(['analyticsDisabled', 'streamsDisabled', 'streamsDisabled']);
+    validateColumnValues('enabledFeaturesTable', ['Analytics', 'Streams', 'Tasks', 'Skipper Mode'], 0);
+    validateSpansExists(['analyticsDisabled', 'streamsDisabled', 'tasksDisabled', 'skipperDisabled']);
 
     // Verify Security Information
     validateColumnValues('securityInformationTable', ['Authentication', 'Authorization',

ui/src/app/about/about.service.spec.ts

@@ -11,7 +11,8 @@ describe('AboutService', () => {
       {
           'analyticsEnabled': true,
           'streamsEnabled': true,
-          'tasksEnabled': true
+          'tasksEnabled': true,
+          'skipperEnabled': true
       },
       'versionInfo':
       {

ui/src/app/shared/model/about/feature-info.model.spec.ts

@@ -24,20 +24,24 @@ describe('FeatureInfo', () => {
       expect(featureInfo.analyticsEnabled).toBe(false);
       expect(featureInfo.streamsEnabled).toBe(false);
       expect(featureInfo.tasksEnabled).toBe(false);
+      expect(featureInfo.skipperEnabled).toBe(false);
 
       featureInfo.analyticsEnabled = true;
       featureInfo.streamsEnabled = true;
       featureInfo.tasksEnabled = true;
+      featureInfo.skipperEnabled = true;
 
       expect(featureInfo.analyticsEnabled).toBe(true);
       expect(featureInfo.streamsEnabled).toBe(true);
       expect(featureInfo.tasksEnabled).toBe(true);
+      expect(featureInfo.skipperEnabled).toBe(true);
 
       featureInfo.reset();
 
       expect(featureInfo.analyticsEnabled).toBe(false);
       expect(featureInfo.streamsEnabled).toBe(false);
       expect(featureInfo.tasksEnabled).toBe(false);
+      expect(featureInfo.skipperEnabled).toBe(false);
     });
   });
   describe('isFeatureEnabled', () => {
@@ -47,16 +51,19 @@ describe('FeatureInfo', () => {
       featureInfo.analyticsEnabled = true;
       featureInfo.streamsEnabled = true;
       featureInfo.tasksEnabled = true;
+      featureInfo.skipperEnabled = true;
 
       expect(featureInfo.isFeatureEnabled('analyticsEnabled')).toBe(true);
       expect(featureInfo.isFeatureEnabled('streamsEnabled')).toBe(true);
       expect(featureInfo.isFeatureEnabled('tasksEnabled')).toBe(true);
+      expect(featureInfo.isFeatureEnabled('skipperEnabled')).toBe(true);
     });
     it('should show that the standard features are disabled by default', () => {
       const featureInfo = new FeatureInfo();
       expect(featureInfo.isFeatureEnabled('analyticsEnabled')).toBe(false);
       expect(featureInfo.isFeatureEnabled('streamsEnabled')).toBe(false);
       expect(featureInfo.isFeatureEnabled('tasksEnabled')).toBe(false);
+      expect(featureInfo.isFeatureEnabled('skipperEnabled')).toBe(false);
     });
     it('should show that unsupported features return false', () => {
       const featureInfo = new FeatureInfo();

ui/src/app/shared/model/about/feature-info.model.ts

@@ -10,6 +10,7 @@ export class FeatureInfo implements Serializable<FeatureInfo> {
   public analyticsEnabled = false;
   public streamsEnabled = false;
   public tasksEnabled = false;
+  public skipperEnabled = false;
 
   /**
    * Set the FeatureInfo object to default values.
@@ -18,12 +19,14 @@ export class FeatureInfo implements Serializable<FeatureInfo> {
     this.analyticsEnabled = false;
     this.streamsEnabled = false;
     this.tasksEnabled = false;
+    this.skipperEnabled = false;
   }
 
   public deserialize(input) {
     this.analyticsEnabled = input.analyticsEnabled;
     this.streamsEnabled = input.streamsEnabled;
     this.tasksEnabled = input.tasksEnabled;
+    this.skipperEnabled = input.skipperEnabled;
     return this;
   }
 
@@ -45,6 +48,9 @@ export class FeatureInfo implements Serializable<FeatureInfo> {
         case 'tasksEnabled': {
           return this.tasksEnabled;
         }
+        case 'skipperEnabled': {
+          return this.skipperEnabled;
+        }
         default: {
           console.error(`Unsupported feature parameter '${feature}'.`);
           return false;

ui/src/app/tests/mocks/about.ts

@@ -105,6 +105,7 @@ export class DataflowVersionInfo {
     this.featureInfo.analyticsEnabled = true;
     this.featureInfo.streamsEnabled = true;
     this.featureInfo.tasksEnabled = true;
+    this.featureInfo.skipperEnabled = true;
   }
 }
 
@@ -162,6 +163,7 @@ export class MockAboutService {
         dataFlowVersion.featureInfo.analyticsEnabled = false;
         dataFlowVersion.featureInfo.streamsEnabled = false;
         dataFlowVersion.featureInfo.tasksEnabled = false;
+        dataFlowVersion.featureInfo.skipperEnabled = false;
       }
       if (!this.isPlatformSpecificInformationAvailable) {
         dataFlowVersion.runtimeEnvironment.taskLauncher.platformSpecificInfo = {};