Routing History back: fix bug

oodamien · ghillert · commit 3ddfe7e32d32 · 2018-06-27T09:55:32.000-10:00
diff --git a/ui/src/app/shared/services/routing-state.service.ts b/ui/src/app/shared/services/routing-state.service.ts
@@ -58,8 +58,10 @@ export class RoutingStateService {
         .find((history) => {
           return !isNotRegex || !(isNotRegex.test(history.url));
         });
-      this.history = this.history.slice(0, this.history.indexOf(item));
-      url = item.url;
+      if (item) {
+        this.history = this.history.slice(0, this.history.indexOf(item));
+        url = item.url;
+      }
     }
     this.router.navigate([url]);
   }

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,10 @@ export class RoutingStateService {`
`58`	`58`	`.find((history) => {`
`59`	`59`	`return !isNotRegex \|\| !(isNotRegex.test(history.url));`
`60`	`60`	`});`
`61`		`- this.history = this.history.slice(0, this.history.indexOf(item));`
`62`		`- url = item.url;`
	`61`	`+ if (item) {`
	`62`	`+ this.history = this.history.slice(0, this.history.indexOf(item));`
	`63`	`+ url = item.url;`
	`64`	`+ }`
`63`	`65`	`}`
`64`	`66`	`this.router.navigate([url]);`
`65`	`67`	`}`