gh-852 Use a dedicated UUID/GUID library

* Add `node-uuid` dependency
* Update code
* Ensure that lint errors pertaining to `Forbidden bitwise operation` no longer occur

Author: ghillert

ui/package.json

@@ -51,7 +51,8 @@
     "jshint": "2.9.5",
     "spring-flo": "0.8.0",
     "ng-busy": "1.4.4",
-    "rxjs-compat": "^6.2.1"
+    "rxjs-compat": "^6.2.1",
+    "uuid": "3.3.2"
   },
   "devDependencies": {
     "@angular/compiler-cli": "6.0.7",
@@ -62,6 +63,7 @@
     "@types/jasmine": "2.8.8",
     "@types/jasminewd2": "2.0.3",
     "@types/node": "8.9.5",
+    "@types/uuid": "3.4.3",
     "codelyzer": "4.2.1",
     "jasmine-core": "2.99.1",
     "jasmine-spec-reporter": "4.2.1",

ui/src/app/shared/services/group-route.service.ts

@@ -1,8 +1,10 @@
 import { Injectable } from '@angular/core';
 import { LocalStorageService } from 'angular-2-local-storage';
 
+import * as uuidv4 from 'uuid/v4';
+
 /**
- * A service for global logs.
+ * A service for create group route.
  *
  * @author Damien Vitrac
  */
@@ -12,11 +14,16 @@ export class GroupRouteService {
   constructor(private localStorageService: LocalStorageService) {
   }
 
+  /**
+   * Create an unique UUID
+   * Format:
+   * 6ba7b810-9dad-11d1-80b4-00c04fd430c8
+   *
+   * @param args
+   * @returns {string}
+   */
   create(args): string {
-    const key = `group-${'xxxxx-xxxxx-xxxxx-xxxxx'.replace(/[xy]/g, function (c) {
-      const r = Math.random() * 16 | 0, v = c === 'x' ? r : (r & 0x3 | 0x8);
-      return v.toString(16);
-    })}`;
+    const key = 'group-' + uuidv4();
     this.localStorageService.set(key, args);
     return key;
   }
@@ -26,7 +33,8 @@ export class GroupRouteService {
     if (!str.startsWith('group-')) {
       return false;
     }
-    if (str.length !== 29 || str[11] !== '-' || str[17] !== '-' || str[23] !== '-') {
+    const g = `group-`.length;
+    if (str.length !== (36 + g) || str[(8 + g)] !== '-' || str[(13 + g)] !== '-' || str[(18 + g)] !== '-' || str[(23 + g)] !== '-') {
       return false;
     }
     return true;

ui/src/app/tests/mocks/group-route.ts

@@ -1,3 +1,5 @@
+import * as uuidv4 from 'uuid/v4';
+
 /**
  * A service for group route.
  *
@@ -12,10 +14,7 @@ export class MockGroupRouteService {
   }
 
   create(args): string {
-    const key = `group-${'xxxxx-xxxxx-xxxxx-xxxxx'.replace(/[xy]/g, function (c) {
-      const r = Math.random() * 16 | 0, v = c === 'x' ? r : (r & 0x3 | 0x8);
-      return v.toString(16);
-    })}`;
+    const key = 'group-' + uuidv4();
     this._group[key] = args;
     this.last = {
       key: key,
@@ -29,7 +28,8 @@ export class MockGroupRouteService {
     if (!str.startsWith('group-')) {
       return false;
     }
-    if (str.length !== 29 || str[11] !== '-' || str[17] !== '-' || str[23] !== '-') {
+    const g = `group-`.length;
+    if (str.length !== (36 + g) || str[(8 + g)] !== '-' || str[(13 + g)] !== '-' || str[(18 + g)] !== '-' || str[(23 + g)] !== '-') {
       return false;
     }
     return true;