Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 2828166

Browse files
committed
Re-enable Stream deploy options for Skipper mode
Resolve #594 - enable the deploy checkbox in stream-create dialog - enable the generic stream deployment button - remove the skipper not-supported button
1 parent f008380 commit 2828166

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

ui/src/app/streams/stream-create-dialog/stream-create-dialog.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ <h4 class="modal-title pull-left">Create Stream</h4>
4040
</td>
4141
</tr>
4242
</tbody>
43-
<label class="dialog-control" *ngIf="(featureInfo | async) && !(featureInfo | async)?.skipperEnabled">
43+
<label class="dialog-control">
4444
<input [disabled]="isStreamCreationInProgress()" type="checkbox" [(ngModel)]="deploy"
4545
[ngModelOptions]="{standalone: true}"/>Deploy stream(s)
4646
</label>

ui/src/app/streams/stream-definitions/stream-definitions.component.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,10 @@
9999
<span class="glyphicon glyphicon-stop"></span>
100100
</button>
101101

102-
<button *ngIf="!(featureInfo | async)?.skipperEnabled" type="button" [appRoles]="['ROLE_CREATE']" [disabled]="(item.status==='deployed' || item.status==='deploying')" (click)="deploy(item)"
102+
<button type="button" [appRoles]="['ROLE_CREATE']" [disabled]="(item.status==='deployed' || item.status==='deploying')" (click)="deploy(item)"
103103
class="btn btn-default" style="margin-left: 0;" title="Deploy">
104104
<span class="glyphicon glyphicon-play"></span>
105105
</button>
106-
<button *ngIf="(featureInfo | async)?.skipperEnabled" type="button" [appRoles]="['ROLE_CREATE']" class="btn btn-default" style="margin-left: 0;"
107-
popover="Switch to the Shell to deploy a stream using Skipper. The Dashboard support for it is under development" popoverTitle="Unsupported" placement="bottom" triggers="focus">
108-
<span class="glyphicon glyphicon-play"></span>
109-
</button>
110106

111107
<button type="button" [appRoles]="['ROLE_CREATE']" (click)="destroy(item)"
112108
class="btn btn-default" style="margin-left: 0;" title="Destroy">

0 commit comments

Comments
 (0)