Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 1d63652

Browse files
committed
Resolves bugs identified in lint.
* Removes the status column in task definition page. The missing popup was missing and when researching what was to be put in it, it was incorrect in the 1.2.x line. And since task status made no sense in the previous release nor here so it was removed. * Removed code to retrieve job execution ids since it is not implemented in the class. * Used a for loop to populate the platform specific information in the about detail. Please review this for style, took a swag at what we wanted. resolves #319
1 parent 7f93116 commit 1d63652

File tree

3 files changed

+8
-14
lines changed

3 files changed

+8
-14
lines changed

ui/src/app/about/about-details.component.html

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,11 @@ <h2>Platform-specific Information of the App Deployer</h2>
141141

142142
<table class="table table-hover">
143143
<tbody>
144-
<tr *ngIf="!isEmpty(dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo)" ng-repeat="(key, value) in dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo">
145-
<td class="col-xs-6">{{key}}</td><td>{{value}}</td>
144+
<tr *ngIf="!isEmpty(dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo)">
145+
<ng-template ngFor let-item
146+
[ngForOf]="dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo | keyvalues">
147+
<td class="col-xs-6">{{item.key}}</td><td>{{item.value}}</td>
148+
</ng-template>
146149
</tr>
147150
<tr *ngIf="isEmpty(dataflowVersionInfo.runtimeEnvironment.appDeployer.platformSpecificInfo)">
148151
<td class="col-xs-12 text-center" colspan="2">No platform-specific app deployer information available.</td>
@@ -206,4 +209,4 @@ <h2>Platform-specific Information of the Task Launcher</h2>
206209
[ngxClipboard] [cbContent]="dataflowVersionInfo | json" (cbOnSuccess)="onCopyToClipboardSuccess($event);"
207210
type="button" class="btn btn-default"><span class="glyphicon glyphicon-copy"></span> Copy Details to Clipboard</button></div>
208211
</div>
209-
</div>
212+
</div>

ui/src/app/tasks/task-definitions/task-definitions.component.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,6 @@
2929
<tr>
3030
<th style="width: 70px" table-sort sort-property="['DEFINITION_NAME', 'DEFINITION']" sort-state="pageable" sort-order-change-handler="sortChanged">Name</th>
3131
<th style="width: 300px" table-sort sort-property="['DEFINITION','DEFINITION_NAME']" sort-state="pageable" sort-order-change-handler="sortChanged">Definition</th>
32-
<th style="width: 50px">Status
33-
<a #childPopover="bs-popover"
34-
[popover]="popTemplate"
35-
placement="bottom"
36-
(clickOutside)="closePopOver()"
37-
title="Available Deployment Statuses"><span class="glyphicon glyphicon-question-sign"></span></a>
38-
</th>
3932
<th style="width: 240px" colspan="1" class="text-center">Actions</th>
4033
</tr>
4134
</thead>
@@ -45,7 +38,6 @@
4538
<tr>
4639
<td>{{item.name}}</td>
4740
<td>{{item.dslText}}</td>
48-
<td>{{item.status}}</td>
4941
<td class="action-column">
5042
<button type="button" (click)="launchTask(item)"
5143
class="btn btn-default" title="Launch">
@@ -85,3 +77,4 @@ <h4 class="modal-title pull-left">Confirm Destroy Action</h4>
8577
</div>
8678
</div>
8779
</div>
80+

ui/src/app/tasks/task-details/task-details.component.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@
4141
</tr>
4242
<tr>
4343
<td>Job Execution Ids</td>
44-
<td>
45-
<span *ngFor="let jobExecutionId of taskExecution.jobExecutionIds"><button type="button" class="btn btn-default" (click)="viewJobExecutionDetails(jobExecutionId)" title="Details">{{jobExecutionId}}</button>{{$last ? '' : '&nbsp;'}}</span>
46-
</td>
44+
<td></td>
4745
</tr>
4846
<tr>
4947
<td>Start Time</td>

0 commit comments

Comments
 (0)