From ca013b8b8fe8ea6321061d412d36ac7e2083151a Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 15:13:21 +0530 Subject: [PATCH 1/6] fix: skip running tests on changes in validate-deploy-docs.yaml --- .github/workflows/reusable-build-test-release.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index 083d421e..de38406d 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -133,15 +133,15 @@ jobs: - name: Fetch all refs run: git fetch --prune --unshallow - - name: Check if the changes are only in docs/*, mkdocs.yml, or .github/workflows/docs.yml + - name: Check if the changes are only in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml id: check run: | set -o xtrace # List all files modified in the commit or PR changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) - # Check if any of the changed files are not in docs/*, mkdocs.yml, or .github/workflows/docs.yml - if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml)'; then + # Check if any of the changed files are not in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml + if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml)'; then echo "docs-only=false" >> "$GITHUB_OUTPUT" else echo "Only documentation changes found." From efa9132e7cb32ecdddfc642820463745542a645b Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 15:36:21 +0530 Subject: [PATCH 2/6] chore: adding .github/workflows/build-test-release.yml in skip so custom wf branch can be tested --- .github/workflows/reusable-build-test-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index de38406d..a4f439e8 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -141,7 +141,7 @@ jobs: changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) # Check if any of the changed files are not in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml - if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml)'; then + if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'; then echo "docs-only=false" >> "$GITHUB_OUTPUT" else echo "Only documentation changes found." From fa01648c97f23ecf50c1351f2e55a08e4bef6b35 Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 16:07:03 +0530 Subject: [PATCH 3/6] fix: multiple yml changes breaks grep, use redirection to get clean string --- .github/workflows/reusable-build-test-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index a4f439e8..464ae4f5 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -141,7 +141,7 @@ jobs: changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) # Check if any of the changed files are not in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml - if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'; then + if grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'<<< $(echo "$changed_files"); then echo "docs-only=false" >> "$GITHUB_OUTPUT" else echo "Only documentation changes found." From 00a6dadd4c4b7cb502d8fa6b7b1811e06c0b3ce6 Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 16:20:31 +0530 Subject: [PATCH 4/6] chore: revert change --- .github/workflows/reusable-build-test-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index 464ae4f5..a4f439e8 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -141,7 +141,7 @@ jobs: changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) # Check if any of the changed files are not in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml - if grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'<<< $(echo "$changed_files"); then + if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'; then echo "docs-only=false" >> "$GITHUB_OUTPUT" else echo "Only documentation changes found." From 3d62abde30880ef2f5968fa5b76d91b394bd8178 Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 16:31:38 +0530 Subject: [PATCH 5/6] fix: remove docs.yaml from docs-only change as it is now removed in template repo --- .github/workflows/reusable-build-test-release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index a4f439e8..bd570287 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -140,8 +140,8 @@ jobs: # List all files modified in the commit or PR changed_files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }}) - # Check if any of the changed files are not in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml - if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/docs.yml|.github/workflows/validate-deploy-docs.yaml|.github/workflows/build-test-release.yml)'; then + # Check if any of the changed files are not in docs/*, mkdocs.yml, or .github/workflows/validate-deploy-docs.yaml + if echo "$changed_files" | grep -vqE '^(docs/|mkdocs.yml|.github/workflows/validate-deploy-docs.yaml)'; then echo "docs-only=false" >> "$GITHUB_OUTPUT" else echo "Only documentation changes found." From 62d53ca6190eb86dcef32b256baebc7250a8fa8c Mon Sep 17 00:00:00 2001 From: Siddharth Date: Wed, 25 Jun 2025 16:33:30 +0530 Subject: [PATCH 6/6] chore: remove docs.yaml from step name --- .github/workflows/reusable-build-test-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-build-test-release.yml b/.github/workflows/reusable-build-test-release.yml index bd570287..0b6a2ac1 100644 --- a/.github/workflows/reusable-build-test-release.yml +++ b/.github/workflows/reusable-build-test-release.yml @@ -133,7 +133,7 @@ jobs: - name: Fetch all refs run: git fetch --prune --unshallow - - name: Check if the changes are only in docs/*, mkdocs.yml, .github/workflows/docs.yml or .github/workflows/validate-deploy-docs.yaml + - name: Check if the changes are only in docs/*, mkdocs.yml or .github/workflows/validate-deploy-docs.yaml id: check run: | set -o xtrace