chore: update develop with changes on main #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping this PR open to see what will be released. Tested here: https://github.com/splunk/splunk-add-on-for-mysql/actions/runs/9156660157
Test runs: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/9269557494 https://github.com/splunk/test-addonfactory-repo/actions/runs/9270329208 Changes possibly affecting customers: - add ui_marker to enable splitting UI tests execution - fix for failing upload-artifact@v4 due to multiple artifacts with same name - replace edplato/trufflehog-actions-scan action with official trufflehog action latest release - bump version of workflow-engine-base image to v4.0 (Ubuntu 20 -> Ubuntu 22) Changes not affecting customers: - wfe-test-runner-action update to v5 and change of the way that browser is determined in k8s - docs and ci related updates Also note that starting from release v4.16.0 some assets are removed from TA releases: 1. installation-actions.json 2. installation-update.json 3. \<TA-release\>-_forwarders.spl 4. \<TA-release\>-_indexers.spl 5. \<TA-release\>-_search_heads.spl
Recently multiple false positives reported for trufflehog v3: https://splunk.slack.com/archives/CRTNPEZ4M/p1717405810934429 Let's add --only-verified flag to callout to avoid multiple fp for now. Final solution need to be established/reviewed with prodsec. More info on secrets verification in trufflehog: https://trufflesecurity.com/blog/how-trufflehog-verifies-secrets Tests: https://github.com/splunk/splunk-add-on-for-microsoft-office-365/actions/runs/9399856169
mkolasinski-splunk
approved these changes
Jun 21, 2024
|
🎉 This PR is included in version 4.16.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.