Skip to content

Commit 33aca3c

Browse files
feat: exitfirst param to pytest cmd via label (#370)
### Description [ADDON-78360](https://splunk.atlassian.net/browse/ADDON-78360) [CI/CD] Add test label exit-first ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
2 parents b64b238 + 21d6b6f commit 33aca3c

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

.github/workflows/reusable-build-test-release.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ jobs:
129129
execute-scripted_inputs-labeled: ${{ steps.configure-tests-on-labels.outputs.execute_scripted_inputs_labeled }}
130130
execute-requirement-labeled: ${{ steps.configure-tests-on-labels.outputs.execute_requirement_test_labeled }}
131131
execute-upgrade-labeled: ${{ steps.configure-tests-on-labels.outputs.execute_upgrade_test_labeled }}
132+
exit-first: ${{ steps.configure-tests-on-labels.outputs.exit-first }}
132133
s3_bucket_k8s: ${{ steps.k8s-environment.outputs.s3_bucket }}
133134
argo_server_domain_k8s: ${{ steps.k8s-environment.outputs.argo_server_domain }}
134135
argo_token_secret_id_k8s: ${{ steps.k8s-environment.outputs.argo_token_secret_id }}
@@ -225,6 +226,13 @@ jobs:
225226
echo "$test_type""_labeled=${EXECUTE_LABELED["$test_type"]}" >> "$GITHUB_OUTPUT"
226227
echo "$test_type""_labeled: ${EXECUTE_LABELED["$test_type"]}"
227228
done
229+
# exit first fail if label exit-first is present
230+
EXIT_FIRST=""
231+
if ${{ contains(github.event.pull_request.labels.*.name, 'exit-first') }}; then
232+
EXIT_FIRST="-x"
233+
fi
234+
echo "exit-first=${EXIT_FIRST}" >> "$GITHUB_OUTPUT"
235+
echo "exit-first: ${EXIT_FIRST}"
228236
229237
validate-pr-title:
230238
name: Validate PR title
@@ -1114,7 +1122,7 @@ jobs:
11141122
with:
11151123
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
11161124
test-type: ${{ env.TEST_TYPE }}
1117-
test-args: ""
1125+
test-args: ${{ needs.setup-workflow.outputs.exit-first }}
11181126
job-name: ${{ steps.create-job-name.outputs.job-name }}
11191127
labels: ${{ needs.setup.outputs.labels }}
11201128
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -1383,7 +1391,7 @@ jobs:
13831391
with:
13841392
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
13851393
test-type: ${{ env.TEST_TYPE }}
1386-
test-args: ""
1394+
test-args: ${{ needs.setup-workflow.outputs.exit-first }}
13871395
job-name: ${{ steps.create-job-name.outputs.job-name }}
13881396
labels: ${{ needs.setup.outputs.labels }}
13891397
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -1651,7 +1659,7 @@ jobs:
16511659
with:
16521660
splunk: ${{ matrix.splunk.version }}
16531661
test-type: ${{ env.TEST_TYPE }}
1654-
test-args: ""
1662+
test-args: ${{ needs.setup-workflow.outputs.exit-first }}
16551663
job-name: ${{ steps.create-job-name.outputs.job-name }}
16561664
labels: ${{ needs.setup.outputs.labels }}
16571665
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -1855,7 +1863,7 @@ jobs:
18551863
ARGO_NAMESPACE: ${{ needs.setup.outputs.argo-namespace }}
18561864
SPLUNK_VERSION_BASE: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
18571865
TEST_TYPE: "ui"
1858-
TEST_ARGS: "--browser ${{ matrix.browser }}"
1866+
TEST_ARGS: "--browser ${{ matrix.browser }} ${{ needs.setup-workflow.outputs.exit-first }}"
18591867
TEST_BROWSER: ${{ matrix.browser }}
18601868
permissions:
18611869
actions: read
@@ -1922,7 +1930,7 @@ jobs:
19221930
with:
19231931
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
19241932
test-type: ${{ env.TEST_TYPE }}
1925-
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }}
1933+
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }} ${{ needs.setup-workflow.outputs.exit-first }}
19261934
job-name: ${{ steps.create-job-name.outputs.job-name }}
19271935
labels: ${{ needs.setup.outputs.labels }}
19281936
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -2199,7 +2207,7 @@ jobs:
21992207
with:
22002208
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
22012209
test-type: ${{ env.TEST_TYPE }}
2202-
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }}
2210+
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }} ${{ needs.setup-workflow.outputs.exit-first }}
22032211
job-name: ${{ steps.create-job-name.outputs.job-name }}
22042212
labels: ${{ needs.setup.outputs.labels }}
22052213
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -2474,7 +2482,7 @@ jobs:
24742482
with:
24752483
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
24762484
test-type: ${{ env.TEST_TYPE }}
2477-
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }}
2485+
test-args: ${{ env.TEST_ARGS }} ${{ steps.create-test-arg.outputs.test-arg }} ${{ matrix.marker }} ${{ needs.setup-workflow.outputs.exit-first }}
24782486
job-name: ${{ steps.create-job-name.outputs.job-name }}
24792487
labels: ${{ needs.setup.outputs.labels }}
24802488
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}
@@ -3011,7 +3019,7 @@ jobs:
30113019
with:
30123020
splunk: ${{ matrix.splunk.version }}${{ secrets.OTHER_TA_REQUIRED_CONFIGS }}
30133021
test-type: ${{ env.TEST_TYPE }}
3014-
test-args: "--hostname=spl --os-name=${{ steps.os-name-version.outputs.os-name }} --os-version=${{ steps.os-name-version.outputs.os-version }} -m script_input"
3022+
test-args: "--hostname=spl --os-name=${{ steps.os-name-version.outputs.os-name }} --os-version=${{ steps.os-name-version.outputs.os-version }} -m script_input ${{ needs.setup-workflow.outputs.exit-first }}"
30153023
job-name: ${{ steps.create-job-name.outputs.job-name }}
30163024
labels: ${{ needs.setup.outputs.labels }}
30173025
workflow-tmpl-name: ${{ needs.setup.outputs.argo-workflow-tmpl-name }}

0 commit comments

Comments
 (0)