Skip to content

Commit 0f691bb

Browse files
fix: change deps installation method in unit tests (#258)
Currently in unit tests we install dependencies from requirements_dev.txt file, exported by poetry. The problem is that this requirements_dev.txt file contains environment markers with supported versions of pythons - this format causes pip to exit silently ans setup step is successful - job is failing later on run-test step which is unexpected. Changed installation method to `poetry install` Tests: splunk/splunk-add-on-for-google-workspace#547 splunk/splunk-add-on-for-amazon-web-services#1221
1 parent e1cdc3c commit 0f691bb

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/reusable-build-test-release.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -458,20 +458,20 @@ jobs:
458458
pip install poetry==1.5.1 poetry-plugin-export==1.4.0
459459
poetry lock --check
460460
poetry export --without-hashes -o package/lib/requirements.txt
461-
poetry export --without-hashes --dev -o requirements_dev.txt
461+
poetry export --without-hashes --with dev -o requirements_dev.txt
462462
fi
463463
if [ ! -f requirements_dev.txt ]; then echo no requirements;exit 0 ;fi
464464
git config --global --add url."https://${{ secrets.GH_TOKEN_ADMIN }}@github.com".insteadOf https://github.com
465465
git config --global --add url."https://${{ secrets.GH_TOKEN_ADMIN }}@github.com".insteadOf ssh://git@github.com
466-
pip install -r requirements_dev.txt
466+
poetry install --with dev
467467
- name: Create directories
468468
run: |
469469
mkdir -p /opt/splunk/var/log/splunk
470470
chmod -R 777 /opt/splunk/var/log/splunk
471471
- name: Copy pytest ini
472472
run: cp tests/unit/pytest-ci.ini pytest.ini
473473
- name: Run Pytest with coverage
474-
run: pytest --cov=./ --cov-report=xml --junitxml=test-results/junit.xml tests/unit
474+
run: poetry run pytest --cov=./ --cov-report=xml --junitxml=test-results/junit.xml tests/unit
475475
- uses: actions/upload-artifact@v3
476476
if: success() || failure()
477477
with:
@@ -509,20 +509,20 @@ jobs:
509509
pip install poetry==1.5.1 poetry-plugin-export==1.4.0
510510
poetry lock --check
511511
poetry export --without-hashes -o package/lib/requirements.txt
512-
poetry export --without-hashes --dev -o requirements_dev.txt
512+
poetry export --without-hashes --with dev -o requirements_dev.txt
513513
fi
514514
if [ ! -f requirements_dev.txt ]; then echo no requirements;exit 0 ;fi
515515
git config --global --add url."https://${{ secrets.GH_TOKEN_ADMIN }}@github.com".insteadOf https://github.com
516516
git config --global --add url."https://${{ secrets.GH_TOKEN_ADMIN }}@github.com".insteadOf ssh://git@github.com
517-
pip install -r requirements_dev.txt
517+
poetry install --with dev
518518
- name: Create directories
519519
run: |
520520
mkdir -p /opt/splunk/var/log/splunk
521521
chmod -R 777 /opt/splunk/var/log/splunk
522522
- name: Copy pytest ini
523523
run: cp tests/unit/pytest-ci.ini pytest.ini
524524
- name: Run Pytest with coverage
525-
run: pytest --cov=./ --cov-report=xml --junitxml=test-results/junit.xml tests/unit
525+
run: poetry run pytest --cov=./ --cov-report=xml --junitxml=test-results/junit.xml tests/unit
526526
- uses: actions/upload-artifact@v3
527527
if: success() || failure()
528528
with:
@@ -573,7 +573,7 @@ jobs:
573573
echo "No prod dependencies were found"
574574
rm requirements.txt
575575
fi
576-
poetry export --without-hashes --dev -o requirements_dev.txt
576+
poetry export --without-hashes --with dev -o requirements_dev.txt
577577
cat requirements_dev.txt
578578
fi
579579
- name: Get pip cache dir
@@ -745,7 +745,7 @@ jobs:
745745
echo "No prod dependencies were found"
746746
rm requirements.txt
747747
fi
748-
poetry export --without-hashes --dev -o requirements_dev.txt
748+
poetry export --without-hashes --with dev -o requirements_dev.txt
749749
cat requirements_dev.txt
750750
fi
751751
- id: pip-cache

0 commit comments

Comments
 (0)