pr feedback

Author: sanzmauro

go.mod

@@ -3,7 +3,7 @@ module github.com/splitio/go-client/v6
 go 1.18
 
 require (
-	github.com/splitio/go-split-commons/v6 v6.0.3-0.20250107165105-06ac4432a361
+	github.com/splitio/go-split-commons/v6 v6.0.3-0.20250110130515-1d29216e1be4
 	github.com/splitio/go-toolkit/v5 v5.4.0
 )
 

go.sum

@@ -14,10 +14,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/redis/go-redis/v9 v9.0.4 h1:FC82T+CHJ/Q/PdyLW++GeCO+Ol59Y4T7R4jbgjvktgc=
 github.com/redis/go-redis/v9 v9.0.4/go.mod h1:WqMKv5vnQbRuZstUwxQI195wHy+t4PuXDOjzMvcuQHk=
-github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9 h1:UvtXnoIddjx8KOgJ0GqAz/FL4UtkfNyfElM4rz04GgM=
-github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
-github.com/splitio/go-split-commons/v6 v6.0.3-0.20250107165105-06ac4432a361 h1:VYLTOxshKSJEsJw77qpvRScPnG6/lARioZmfvHWKwsE=
-github.com/splitio/go-split-commons/v6 v6.0.3-0.20250107165105-06ac4432a361/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250110130515-1d29216e1be4 h1:Y+WYCUZ9XNszNVSXBiqNi8IYQgaCZWkvhf10GW7cpII=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250110130515-1d29216e1be4/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
 github.com/splitio/go-toolkit/v5 v5.4.0 h1:g5WFpRhQomnXCmvfsNOWV4s5AuUrWIZ+amM68G8NBKM=
 github.com/splitio/go-toolkit/v5 v5.4.0/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
 github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=

splitio/client/client.go

@@ -93,7 +93,7 @@ func (c *SplitClient) getEvaluationsResult(matchingKey string, bucketingKey *str
 }
 
 // createImpression creates impression to be stored and used by listener
-func (c *SplitClient) createImpression(featureFlag string, bucketingKey *string, evaluationLabel string, matchingKey string, treatment string, changeNumber int64) dtos.Impression {
+func (c *SplitClient) createImpression(featureFlag string, bucketingKey *string, evaluationLabel string, matchingKey string, treatment string, changeNumber int64, disabled bool) dtos.Impression {
 	var label string
 	if c.factory.cfg.LabelsEnabled {
 		label = evaluationLabel
@@ -112,18 +112,12 @@ func (c *SplitClient) createImpression(featureFlag string, bucketingKey *string,
 		Label:        label,
 		Treatment:    treatment,
 		Time:         time.Now().UTC().UnixNano() / int64(time.Millisecond), // Convert standard timestamp to java's ms timestamps
-	}
-}
-
-func (c *SplitClient) createImpressionDecorated(featureFlag string, bucketingKey *string, matchingKey string, evaluationResult evaluator.Result) dtos.ImpressionDecorated {
-	return dtos.ImpressionDecorated{
-		Impression: c.createImpression(featureFlag, bucketingKey, evaluationResult.Label, matchingKey, evaluationResult.Treatment, evaluationResult.SplitChangeNumber),
-		Disabled:   evaluationResult.ImpressionsDisabled,
+		Disabled:     disabled,
 	}
 }
 
 // storeData stores impression, runs listener and stores metrics
-func (c *SplitClient) storeData(impressions []dtos.ImpressionDecorated, attributes map[string]interface{}, metricsLabel string, evaluationTime time.Duration) {
+func (c *SplitClient) storeData(impressions []dtos.Impression, attributes map[string]interface{}, metricsLabel string, evaluationTime time.Duration) {
 	// Store impression
 	if c.impressions != nil {
 		listenerEnabled := c.impressionListener != nil
@@ -188,7 +182,7 @@ func (c *SplitClient) doTreatmentCall(key interface{}, featureFlag string, attri
 	}
 
 	c.storeData(
-		[]dtos.ImpressionDecorated{c.createImpressionDecorated(featureFlag, bucketingKey, matchingKey, *evaluationResult)},
+		[]dtos.Impression{c.createImpression(featureFlag, bucketingKey, evaluationResult.Label, matchingKey, evaluationResult.Treatment, evaluationResult.SplitChangeNumber, evaluationResult.ImpressionsDisabled)},
 		attributes,
 		metricsLabel,
 		evaluationResult.EvaluationTime,
@@ -229,7 +223,7 @@ func (c *SplitClient) generateControlTreatments(featureFlagNames []string, opera
 }
 
 func (c *SplitClient) processResult(result evaluator.Results, operation string, bucketingKey *string, matchingKey string, attributes map[string]interface{}, metricsLabel string) (t map[string]TreatmentResult) {
-	var bulkImpressions []dtos.ImpressionDecorated
+	var bulkImpressions []dtos.Impression
 	treatments := make(map[string]TreatmentResult)
 	for feature, evaluation := range result.Evaluations {
 		if !c.validator.IsSplitFound(evaluation.Label, feature, operation) {
@@ -238,7 +232,7 @@ func (c *SplitClient) processResult(result evaluator.Results, operation string,
 				Config:    nil,
 			}
 		} else {
-			bulkImpressions = append(bulkImpressions, c.createImpressionDecorated(feature, bucketingKey, matchingKey, evaluation))
+			bulkImpressions = append(bulkImpressions, c.createImpression(feature, bucketingKey, evaluation.Label, matchingKey, evaluation.Treatment, evaluation.SplitChangeNumber, evaluation.ImpressionsDisabled))
 
 			treatments[feature] = TreatmentResult{
 				Treatment: evaluation.Treatment,

splitio/impressions/builder.go

@@ -53,7 +53,7 @@ func BuildInMemoryManager(
 	noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
 
 	if cfg.ImpressionsMode == config.ImpressionsModeNone {
-		impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)
+		impManager := provisional.NewImpressionManagerImp(noneStrategy, noneStrategy)
 		return impManager, nil
 	}
 
@@ -102,7 +102,7 @@ func BuildRedisManager(
 	noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
 
 	if cfg.ImpressionsMode == config.ImpressionsModeNone {
-		impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)
+		impManager := provisional.NewImpressionManagerImp(noneStrategy, noneStrategy)
 		return impManager, nil
 	}