Skip to content

Commit 24de6f8

Browse files
sanzmaurosanzmauro
committed
polishing
1 parent 271390f commit 24de6f8

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/splitio/go-client/v6
33
go 1.18
44

55
require (
6-
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241211200100-36a7e1a3eeb9
6+
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241212182204-626e0eae79d0
77
github.com/splitio/go-toolkit/v5 v5.4.0
88
)
99

‎go.sum‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ github.com/splitio/go-split-commons/v6 v6.0.2 h1:uvrNjyGCOHUjxVTB1pDUA+UB20Wypox
1818
github.com/splitio/go-split-commons/v6 v6.0.2/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
1919
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241211200100-36a7e1a3eeb9 h1:H5ALS64HcbNiEQyT8fLKPck9qEMpSjwM9DYeG0bvvTg=
2020
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241211200100-36a7e1a3eeb9/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
21+
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241212182204-626e0eae79d0 h1:8udmFWKfa/vPyMSLqupxwHkXv1DxJum77XXY0AeNQZE=
22+
github.com/splitio/go-split-commons/v6 v6.0.3-0.20241212182204-626e0eae79d0/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
2123
github.com/splitio/go-toolkit/v5 v5.4.0 h1:g5WFpRhQomnXCmvfsNOWV4s5AuUrWIZ+amM68G8NBKM=
2224
github.com/splitio/go-toolkit/v5 v5.4.0/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
2325
github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=

‎splitio/client/client_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func getFactory() SplitFactory {
140140
impressionObserver, _ := strategy.NewImpressionObserver(500)
141141
impressionsCounter := strategy.NewImpressionsCounter()
142142
impressionsStrategy := strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryStorage, false)
143-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
143+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
144144

145145
return SplitFactory{
146146
cfg: cfg,
@@ -166,7 +166,7 @@ func getFactoryByFlagSets() SplitFactory {
166166
impressionObserver, _ := strategy.NewImpressionObserver(500)
167167
impressionsCounter := strategy.NewImpressionsCounter()
168168
impressionsStrategy := strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryStorage, false)
169-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
169+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
170170

171171
return SplitFactory{
172172
cfg: cfg,
@@ -473,7 +473,7 @@ func TestClientPanicking(t *testing.T) {
473473
impressionObserver, _ := strategy.NewImpressionObserver(500)
474474
impressionsCounter := strategy.NewImpressionsCounter()
475475
impressionsStrategy := strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryMockedStorage, false)
476-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
476+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
477477

478478
factory := SplitFactory{
479479
cfg: cfg,
@@ -650,7 +650,7 @@ func getClientForListener() SplitClient {
650650
impressionObserver, _ := strategy.NewImpressionObserver(500)
651651
impressionsCounter := strategy.NewImpressionsCounter()
652652
impressionsStrategy := strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryMockedStorage, true)
653-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
653+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
654654

655655
factory := &SplitFactory{
656656
cfg: cfg,
@@ -1372,7 +1372,7 @@ func TestClient(t *testing.T) {
13721372

13731373
impressionObserver, _ := strategy.NewImpressionObserver(500)
13741374
impressionsStrategy := strategy.NewDebugImpl(impressionObserver, true)
1375-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
1375+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
13761376

13771377
factory := &SplitFactory{cfg: cfg, impressionManager: impressionManager}
13781378
client := SplitClient{

‎splitio/client/factory.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ func setupLocalhostFactory(
534534
return nil, err
535535
}
536536
impressionsStrategy := strategy.NewDebugImpl(impressionObserver, cfg.Advanced.ImpressionListener != nil)
537-
splitFactory.impressionManager = provisional.NewImpressionManager(impressionsStrategy)
537+
splitFactory.impressionManager = provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
538538
setFactory(splitFactory.apikey, splitFactory.logger)
539539

540540
// Call fetching tasks as goroutine

‎splitio/client/input_validator_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func getClient() SplitClient {
9292
impressionObserver, _ := strategy.NewImpressionObserver(500)
9393
impressionsCounter := strategy.NewImpressionsCounter()
9494
impressionsStrategy := strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryMockedStorage, true)
95-
impressionManager := provisional.NewImpressionManager(impressionsStrategy)
95+
impressionManager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
9696

9797
factory := &SplitFactory{cfg: cfg, impressionManager: impressionManager,
9898
storages: sdkStorages{

‎splitio/impressions/builder.go‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ func BuildInMemoryManager(
5353
noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
5454

5555
if cfg.ImpressionsMode == config.ImpressionsModeNone {
56-
return provisional.NewImpressionManager(noneStrategy), nil
56+
impManager := provisional.NewImpressionManager(noneStrategy)
57+
return impManager.(*provisional.ImpressionManagerImpl), nil
5758
}
5859

5960
workers.ImpressionRecorder = impression.NewRecorderSingle(impressionStorage, splitAPI.ImpressionRecorder, logger, metadata, cfg.ImpressionsMode, telemetryStorage)
@@ -72,7 +73,7 @@ func BuildInMemoryManager(
7273
impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryStorage, listenerEnabled)
7374
}
7475

75-
manager := provisional.NewImpressionManager(impressionsStrategy)
76+
manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
7677
manager.SetNoneStrategy(noneStrategy)
7778

7879
return manager, nil
@@ -102,7 +103,8 @@ func BuildRedisManager(
102103
noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
103104

104105
if cfg.ImpressionsMode == config.ImpressionsModeNone {
105-
return provisional.NewImpressionManager(noneStrategy), nil
106+
impManager := provisional.NewImpressionManager(noneStrategy)
107+
return impManager.(*provisional.ImpressionManagerImpl), nil
106108
}
107109

108110
impressionObserver, err := strategy.NewImpressionObserver(500)
@@ -118,7 +120,7 @@ func BuildRedisManager(
118120
impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryRuntimeStorage, listenerEnabled)
119121
}
120122

121-
manager := provisional.NewImpressionManager(impressionsStrategy)
123+
manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
122124
manager.SetNoneStrategy(noneStrategy)
123125

124126
return manager, nil

0 commit comments

Comments
 (0)