Python dict to Zig struct

[boisgera]

Hi everyone,

I was expecting the function f defined by

const V = struct {
    x: f64, 
    y: f64,
}

pub fn f(args: struct {v: V}) f64 {
    return args.v.x * args.v.y;
}

to be exposed as a Python function accepting a dict argument, but this code doesn't build (when used in the ziggy-pydust template with ziggy-pydust 0.25.0).

Any thing wrong that you can spot? Any example of this kind of in the repo that I could learn from?

Cheers,

Sébastien

[jburgy]

Where can we see the entire code and the error message?

[boisgera]

Hi Jan!

Here: https://github.com/boisgera/ziggy-pydust-0.25

poetry build yields:

Preparing build environment with build-system requirements poetry-core, ziggy-pydust==0.25.0
Building ziggy-pydust-template (0.1.0)
  - Building sdist
  - Built ziggy_pydust_template-0.1.0.tar.gz
  - Building wheel
install
└─ install generated to sandbox/_lib.abi3.so
   └─ zig build-lib _lib ReleaseSafe native 1 errors
/tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/pydust/src/types/dict.zig:52:40: error: no field or member function named 'raise' in 'fn (comptime type) type'
                    return py.TypeError.raise("dict missing field " ++ field.name ++ ": " ++ @typeName(field.type));
                           ~~~~~~~~~~~~^~~~~~
error: the following command failed with 1 compilation errors:
/tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/ziglang/zig build-lib -OReleaseSafe --dep pyconf --dep pydust -Mroot=/home/boisgera/tmp/ziggy-pydust-0.25/src/sandbox.zig -Mpyconf=.zig-cache/c/ab225c00b59dbefbfd498264ef582930/options.zig -I /usr/include/python3.12 --dep pyconf=pyconf0 -Mpydust=/tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/pydust/src/pydust.zig -Mpyconf0=.zig-cache/c/ab225c00b59dbefbfd498264ef582930/options.zig -lc -fallow-shlib-undefined --cache-dir .zig-cache --global-cache-dir /home/boisgera/.cache/zig --name _lib -dynamic --zig-lib-dir /tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/ziglang/lib/ --listen=- 
Build Summary: 1/4 steps succeeded; 1 failed
install transitive failure
└─ install generated to sandbox/_lib.abi3.so transitive failure
   └─ zig build-lib _lib ReleaseSafe native 1 errors
error: the following build command failed with exit code 1:
.zig-cache/o/1333ba6cc06128fb3d3e4934819d2173/build /tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/ziglang/zig /tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/ziglang/lib /home/boisgera/tmp/ziggy-pydust-0.25 .zig-cache /home/boisgera/.cache/zig --seed 0x329f6697 -Z08c154d897678ad3 install -Dpython-exe=/tmp/tmpoa6mhqyd/.venv/bin/python -Doptimize=ReleaseSafe
Traceback (most recent call last):
  File "/home/boisgera/tmp/ziggy-pydust-0.25/build.py", line 4, in <module>
    build()
  File "/tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/pydust/build.py", line 22, in build
    buildzig.zig_build(["install", f"-Dpython-exe={sys.executable}", "-Doptimize=ReleaseSafe"])
  File "/tmp/tmpoa6mhqyd/.venv/lib/python3.12/site-packages/pydust/buildzig.py", line 55, in zig_build
    subprocess.run(cmds, check=True)
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/tmp/tmpoa6mhqyd/.venv/bin/python', '-m', 'ziglang', 'build', '--build-file', PosixPath('build.zig'), 'install', '-Dpython-exe=/tmp/tmpoa6mhqyd/.venv/bin/python', '-Doptimize=ReleaseSafe']' returned non-zero exit status 1.

Command '['/tmp/tmpoa6mhqyd/.venv/bin/python', 'build.py']' returned non-zero exit status 1.

Remove the norm function from sandbox.zig (and the corresponding test from test/test_sanbox.py) and everything works as expected.

[jburgy]

Thank you for sharing, @boisgera. This is 100% a bug introduced by yours truly in #429. Fortunately, #477 fixes.

@robert3005 would you please take a look at #477?

[jburgy]

I see @robert3005 merged #477 already!

@boisgera can you rebuild your example fetching from main until @robert3005 publishes a new tagged version?

[boisgera]

I have tried to edit the pyproject.toml file to depend on the develop branch but the [build-system] section doesn't allow that AFAICT. Then tried to spin off poetry inside a pixi environment where pydust was (supposedly) installed from develop but it did not work. I'm afraid I don't have enough poetry-fu to do that (I don't usually deal with poetry), but if this is ok with you I'll test as soon as the 0.25.1 release is out!

Thanks for your help! 👍

[boisgera]

I have tested the code in https://github.com/boisgera/ziggy-pydust-0.25 with the 0.25.1 release, and that works as expected 👍

Thank you @jburgy and @robert3005!

$ poetry run pytest
============================================================== test session starts ==============================================================
platform linux -- Python 3.12.3, pytest-7.4.4, pluggy-1.4.0
rootdir: /home/boisgera/tmp/ziggy-pydust-0.25
collected 2 items

test/test_sandbox.py ..                                                                                                                   [100%]

=============================================================== 2 passed in 0.01s ===============================================================

[jburgy]

Sébastien, would you consider contributing the failing code as a test to prevent a regression?