Remove wasi-experimental-http support

- Update Rust SDK outbound_http implementation to use the newer
  WIT-based interface instead
- Update docs
- Add `make check-rust-examples` target to aid testing
  - Fix unrelated rust-outbound-redis example failure

Signed-off-by: Lann Martin <lann.martin@fermyon.com>

Author: lann

Cargo.lock

@@ -14,6 +14,12 @@ lint:
 	cargo clippy --all-targets --all-features -- -D warnings
 	cargo fmt --all -- --check
 
+.PHONY: check-rust-examples
+check-rust-examples:
+	for manifest_path in examples/*/Cargo.toml; do \
+		cargo clippy --manifest-path "$${manifest_path}" -- -D warnings || exit 1 ; \
+	done
+
 .PHONY: test-unit
 test-unit:
 	RUST_LOG=$(LOG_LEVEL) cargo test --all --no-fail-fast -- --skip integration_tests --nocapture --include-ignored

Makefile

@@ -19,5 +19,4 @@ tokio = { version = "1.4.0", features = [ "full" ] }
 tracing = { version = "0.1", features = [ "log" ] }
 tracing-futures = "0.2"
 url = "2.2.1"
-wasi-experimental-http-wasmtime = "0.10.0"
 wit-bindgen-wasmtime = { git = "https://github.com/bytecodealliance/wit-bindgen", rev = "dde4694aaa6acf9370206527a798ac4ba6a8c5b8" }

crates/outbound-http/Cargo.toml

@@ -1,38 +1,30 @@
 use anyhow::Result;
+use wit_bindgen_wasmtime::wasmtime::Linker;
+
 use spin_engine::{
     host_component::{HostComponent, HostComponentsStateHandle},
     RuntimeContext,
 };
 use spin_manifest::CoreComponent;
-use wasi_experimental_http_wasmtime::{HttpCtx as ExperimentalHttpCtx, HttpState};
-use wit_bindgen_wasmtime::wasmtime::Linker;
 
 use crate::OutboundHttp;
 
 pub struct OutboundHttpComponent;
 
 impl HostComponent for OutboundHttpComponent {
-    type State = (OutboundHttp, ExperimentalHttpCtx);
+    type State = OutboundHttp;
 
     fn add_to_linker<T>(
         linker: &mut Linker<RuntimeContext<T>>,
         data_handle: HostComponentsStateHandle<Self::State>,
     ) -> Result<()> {
-        crate::add_to_linker(linker, move |ctx| &mut data_handle.get_mut(ctx).0)?;
-        HttpState::new()
-            .expect("HttpState::new failed")
-            .add_to_linker(linker, move |ctx| data_handle.get(ctx).1.clone())?;
+        crate::add_to_linker(linker, move |ctx| data_handle.get_mut(ctx))?;
         Ok(())
     }
 
     fn build_state(&self, component: &CoreComponent) -> Result<Self::State> {
-        let outbound_http = OutboundHttp {
-            allowed_hosts: Some(component.wasm.allowed_http_hosts.clone()),
-        };
-        let experimental_http = ExperimentalHttpCtx {
+        Ok(OutboundHttp {
             allowed_hosts: Some(component.wasm.allowed_http_hosts.clone()),
-            max_concurrent_requests: None,
-        };
-        Ok((outbound_http, experimental_http))
+        })
     }
 }

crates/outbound-http/src/host_component.rs

@@ -82,8 +82,7 @@ Each `component` object has the following fields:
     WebAssembly module. For example
     `{ source = "content/", destination = "/"}`.
 - `allowed_http_hosts` (OPTIONAL): List of HTTP hosts the component is allowed
-  to make HTTP requests to (using the
-  [WASI experimental HTTP library](https://github.com/deislabs/wasi-experimental-http))
+  to make HTTP requests to
 - `trigger` (REQUIRED): Trigger configuration for the component. Triggers are
   the components that generate events that cause the execution of components.
   The trigger configuration for a component must be compatible with the top-level

docs/content/configuration.md

@@ -146,8 +146,7 @@ record response {
 ```
 
 > The same HTTP types are also used to model the API for sending outbound
-> HTTP requests, and you can see its implementation in
-> [the WASI toolkit repository](https://github.com/fermyon/wasi-experimental-toolkit).
+> HTTP requests.
 
 Then, we define the entry point for a Spin HTTP component: