Remove mypy overrides from tests.test_directives.test_directive_only (#13692)

Author: AA-Turner

pyproject.toml

@@ -304,7 +304,6 @@ module = [
     # tests/test_config
     "tests.test_config.test_config",
     # tests/test_directives
-    "tests.test_directives.test_directive_only",
     "tests.test_directives.test_directive_other",
     "tests.test_directives.test_directive_patch",
     # tests/test_domains

tests/test_directives/test_directive_only.py

@@ -9,44 +9,53 @@
 from docutils import nodes
 
 if TYPE_CHECKING:
+    from typing import Any
+
     from sphinx.testing.util import SphinxTestApp
 
 
 @pytest.mark.sphinx('text', testroot='directive-only')
 def test_sectioning(app: SphinxTestApp) -> None:
-    def getsects(section):
-        if not isinstance(section, nodes.section):
-            return [getsects(n) for n in section.children]
-        title = section.next_node(nodes.title).astext().strip()
-        subsects = []
-        children = section.children[:]
-        while children:
-            node = children.pop(0)
-            if isinstance(node, nodes.section):
-                subsects.append(node)
-                continue
-            children = list(node.children) + children
-        return [title, [getsects(subsect) for subsect in subsects]]
-
-    def testsects(prefix, sects, indent=0):
-        title = sects[0]
-        parent_num = title.split()[0]
-        assert prefix == parent_num, f'Section out of place: {title!r}'
-        for i, subsect in enumerate(sects[1]):
-            num = subsect[0].split()[0]
-            assert re.match('[0-9]+[.0-9]*[.]', num), (
-                f'Unnumbered section: {subsect[0]!r}'
-            )
-            testsects(prefix + str(i + 1) + '.', subsect, indent + 4)
-
     app.build(filenames=[app.srcdir / 'only.rst'])
     doctree = app.env.get_doctree('only')
     app.env.apply_post_transforms(doctree, 'only')
 
-    parts = [getsects(n) for n in doctree.children if isinstance(n, nodes.section)]
-    for i, s in enumerate(parts):
-        testsects(str(i + 1) + '.', s, 4)
-    actual_headings = '\n'.join(p[0] for p in parts)
+    parts = [_get_sections(n) for n in doctree.children if isinstance(n, nodes.section)]
+    for i, section in enumerate(parts):
+        _test_sections(f'{i + 1}.', section, 4)
+    actual_headings = '\n'.join(p[0] for p in parts)  # type: ignore[misc]
     assert len(parts) == 4, (
         f'Expected 4 document level headings, got:\n{actual_headings}'
     )
+
+
+def _get_sections(section: nodes.Node) -> list[str | list[Any]]:
+    if not isinstance(section, nodes.section):
+        return list(map(_get_sections, section.children))
+    title = section.next_node(nodes.title).astext().strip()
+    subsections = []
+    children = section.children.copy()
+    while children:
+        node = children.pop(0)
+        if isinstance(node, nodes.section):
+            subsections.append(node)
+            continue
+        children = list(node.children) + children
+    return [title, list(map(_get_sections, subsections))]
+
+
+def _test_sections(
+    prefix: str, sections: list[str | list[Any]], indent: int = 0
+) -> None:
+    title = sections[0]
+    assert isinstance(title, str)
+    parent_num = title.partition(' ')[0]
+    assert prefix == parent_num, f'Section out of place: {title!r}'
+    for i, subsection in enumerate(sections[1]):
+        subsection_title = subsection[0]
+        assert isinstance(subsection_title, str)
+        num = subsection_title.partition(' ')[0]
+        assert re.match('[0-9]+[.0-9]*[.]', num), (
+            f'Unnumbered section: {subsection[0]!r}'
+        )
+        _test_sections(f'{prefix}{i + 1}.', subsection, indent + 4)