Avoid passing app to SphinxComponentRegistry._get_publisher() (#13643)

Author: AA-Turner

sphinx/builders/__init__.py

@@ -644,7 +644,9 @@ def read_doc(self, docname: str, *, _cache: bool = True) -> None:
 
         filename = str(env.doc2path(docname))
         filetype = get_filetype(self._app.config.source_suffix, filename)
-        publisher = self._registry.get_publisher(self._app, filetype)
+        publisher = self._registry._get_publisher(
+            filetype, config=self.config, env=self.env
+        )
         self.env.current_document._parser = publisher.parser
         # record_dependencies is mutable even though it is in settings,
         # explicitly re-initialise for each document

sphinx/registry.py

@@ -596,14 +596,16 @@ def get_envversion(self, app: Sphinx) -> Mapping[str, int]:
 
         return _get_env_version(app.extensions)
 
-    def get_publisher(self, app: Sphinx, filetype: str) -> Publisher:
+    def _get_publisher(
+        self, filetype: str, *, config: Config, env: BuildEnvironment
+    ) -> Publisher:
         try:
             return self.publishers[filetype]
         except KeyError:
             pass
-        parser = self.create_source_parser(filetype, config=app.config, env=app.env)
+        parser = self.create_source_parser(filetype, config=config, env=env)
         transforms = self.get_transforms()
-        publisher = _create_publisher(env=app.env, parser=parser, transforms=transforms)
+        publisher = _create_publisher(env=env, parser=parser, transforms=transforms)
         self.publishers[filetype] = publisher
         return publisher