Skip to content

Remove use of __file__ #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jayvdb opened this issue Oct 30, 2022 · 2 comments · May be fixed by #851
Open

Remove use of __file__ #257

jayvdb opened this issue Oct 30, 2022 · 2 comments · May be fixed by #851
Labels
tech debt

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Oct 30, 2022

__file__ is an optional attribute of packages. c.f. indygreg/PyOxidizer#69 for why and alternatives.

spdx/config.py:_base_dir = os.path.dirname(__file__)
@jayvdb jayvdb mentioned this issue Oct 30, 2022
Merged
@nicoweidner
Copy link
Collaborator

The link to the promised solution results in a 404, do you have a different one?
https://pyoxidizer.readthedocs.io/en/latest/packaging_pitfalls.html#reliance-on-file

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 22, 2022

Seems to be now at https://pyoxidizer.readthedocs.io/en/stable/oxidized_importer_behavior_and_compliance.html?highlight=__file__#file-and-cached-module-attributes

bact added a commit to bact/tools-python that referenced this issue Apr 23, 2025
@bact
Use import.resources instead of __file__
84dce36 
Potentially fix spdx#257 and allow zip-safe = true in pyproject.toml

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact linked a pull request Apr 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use import.resources instead of __file__ bact/tools-python
2 participants
@jayvdb @nicoweidner