Fix searchConfigFilesOnDisk to handle empty string parameter #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression from 916d467 where converting null to empty string in searchConfigFiles() broke the ?? operator fallback in searchConfigFilesOnDisk(). Use elvis operator instead to handle both null and empty string.
Contributor
Author
|
Sorry, I should have given some more details: After the mentioned commit the local configuration file in ray.php wasn't loaded any longer because none were found. This addresses #990 as I just realized. Sorry again for being overzealous. |
|
This fix would be great to have merged in. I'm having to manually edit the files to get debugging to work again. |
|
same problem here with php 8.2, the PR solved the problem |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from 916d467 where converting null to empty string in searchConfigFiles() broke the ?? operator fallback in searchConfigFilesOnDisk().
Use elvis operator instead to handle both null and empty string.