Add offset and limit support to trace #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Very nice! Could you like at the failing tests? We can't use named arguments (as we still support 7.4), and something around this functionality changed in PHP 8.4 Ideally we would have the same result for all PHP versions. |
dimitri-koenig
force-pushed
the
feature/trace-offset-limit
branch
from
568a255 to
a9e2ef5
Compare
dimitri-koenig
force-pushed
the
feature/trace-offset-limit
branch
from
a9e2ef5 to
7afc8a8
Compare
Contributor
Author
|
@freekmurze Fixed it |
Member
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traceuseshttps://github.com/spatie/backtraceto properly output the current backtrace. Unfortunately the offset and limit features ofbacktraceare not implemented. This PR solves that.You can then call
ray()->backtrace(limit: 10, offset: 20)to send only a subset of frames.