Add a unique token to route names (#210)

* Adds unique key to route name

* Test mulitple routes for a configuration are unique

Author: ryanlholt

src/WebhookClientServiceProvider.php

@@ -27,7 +27,8 @@ public function packageBooted()
                 throw InvalidMethod::make($method);
             }
 
-            return Route::{$method}($url, '\Spatie\WebhookClient\Http\Controllers\WebhookController')->name("webhook-client-{$name}");
+            return Route::{$method}($url, '\Spatie\WebhookClient\Http\Controllers\WebhookController')
+                ->name("webhook-client-{$name}." . Str::random(8));
         });
 
         $this->app->scoped(WebhookConfigRepository::class, function () {
@@ -43,7 +44,9 @@ public function packageBooted()
         $this->app->bind(WebhookConfig::class, function () {
             $routeName = Route::currentRouteName() ?? '';
 
-            $configName = Str::after($routeName, 'webhook-client-');
+            $routeNameSuffix = Str::after($routeName, 'webhook-client-');
+
+            $configName = Str::before($routeNameSuffix, '.');
 
             $webhookConfig = app(WebhookConfigRepository::class)->getConfig($configName);
 

tests/WebhookControllerTest.php

@@ -204,6 +204,21 @@ public function it_can_store_none_of_the_headers()
         $this->assertEquals(0, count(WebhookCall::first()->headers));
     }
 
+    /** @test */
+    public function multiple_routes_can_share_configuration()
+    {
+        Route::webhooks('incoming-webhooks-additional');
+
+        $this->refreshWebhookConfigRepository();
+
+        $routeNames = collect(Route::getRoutes())
+            ->map(fn ($route) => $route->getName());
+
+        $uniqueRouteNames = $routeNames->unique();
+
+        $this->assertEquals($routeNames->count(), $uniqueRouteNames->count());
+    }
+
     protected function determineSignature(array $payload): string
     {
         $secret = config('webhook-client.configs.0.signing_secret');