skip classes with errors when discovering settings

Author: rubenvanassche

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `laravel-settings` will be documented in this file
 
+## 2.1.2 - 2020-04-08
+
+- skip classes with errors when discovering settings
+
 ## 2.1.1 - 2020-04-07
 
 - add better support for nullable types in docblocks

src/Support/DiscoverSettings.php

@@ -6,6 +6,7 @@
 use Spatie\LaravelSettings\Settings;
 use SplFileInfo;
 use Symfony\Component\Finder\Finder;
+use Throwable;
 
 class DiscoverSettings
 {
@@ -59,9 +60,15 @@ public function discover(): array
         $files = (new Finder())->files()->in($this->directories);
 
         return collect($files)
-            ->reject(fn (SplFileInfo $file) => in_array($file->getPathname(), $this->ignoredFiles))
-            ->map(fn (SplFileInfo $file) => $this->fullQualifiedClassNameFromFile($file))
-            ->filter(fn (string $settingsClass) => is_subclass_of($settingsClass, Settings::class))
+            ->reject(fn(SplFileInfo $file) => in_array($file->getPathname(), $this->ignoredFiles))
+            ->map(fn(SplFileInfo $file) => $this->fullQualifiedClassNameFromFile($file))
+            ->filter(function (string $settingsClass) {
+                try {
+                    return is_subclass_of($settingsClass, Settings::class);
+                } catch (Throwable $e) {
+                    return false;
+                }
+            })
             ->flatten()
             ->toArray();
     }

src/Support/PropertyReflector.php

@@ -103,7 +103,7 @@ private static function reflectCompound(
         Compound $compound
     ): Nullable {
         if ($compound->getIterator()->count() !== 2 || ! $compound->contains(new Null_())) {
-            throw CouldNotResolveDocblockType::create($compound, $reflectionProperty);
+            throw CouldNotResolveDocblockType::create((string) $compound, $reflectionProperty);
         }
 
         $other = current(array_filter(

tests/TestClasses/CrashingClass.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Spatie\LaravelSettings\Tests\TestClasses;
+
+class CrashingClass extends DoesNotExist
+{
+    // This class should be skipped bu the settings discoverer
+    // since it extends from a class that DoesNotExists
+}