Skip to content

Commit 2cca592

Browse files
Merge pull request #249 from spatie/revert-241-main
Revert "Use Illuminate\Database\Eloquent\Casts\Json if possible"
2 parents 9e96701 + 93ff4df commit 2cca592

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

src/SettingsRepositories/DatabaseSettingsRepository.php

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Spatie\LaravelSettings\SettingsRepositories;
44

55
use Illuminate\Database\Eloquent\Builder;
6-
use Illuminate\Database\Eloquent\Casts\Json;
76
use Spatie\LaravelSettings\Models\SettingsProperty;
87

98
class DatabaseSettingsRepository implements SettingsRepository
@@ -28,7 +27,7 @@ public function getPropertiesInGroup(string $group): array
2827
->where('group', $group)
2928
->get(['name', 'payload'])
3029
->mapWithKeys(function (object $object) {
31-
return [$object->name => $this->decode($object->payload, true)];
30+
return [$object->name => json_decode($object->payload, true)];
3231
})
3332
->toArray();
3433
}
@@ -49,15 +48,15 @@ public function getPropertyPayload(string $group, string $name)
4948
->first('payload')
5049
->toArray();
5150

52-
return $this->decode($setting['payload']);
51+
return json_decode($setting['payload']);
5352
}
5453

5554
public function createProperty(string $group, string $name, $payload): void
5655
{
5756
$this->getBuilder()->create([
5857
'group' => $group,
5958
'name' => $name,
60-
'payload' => $this->encode($payload),
59+
'payload' => json_encode($payload),
6160
'locked' => false,
6261
]);
6362
}
@@ -68,7 +67,7 @@ public function updatePropertiesPayload(string $group, array $properties): void
6867
return [
6968
'group' => $group,
7069
'name' => $name,
71-
'payload' => $this->encode($payload),
70+
'payload' => json_encode($payload),
7271
];
7372
})->values()->toArray();
7473

@@ -124,18 +123,4 @@ public function getBuilder(): Builder
124123

125124
return $model->newQuery();
126125
}
127-
128-
private function encode(mixed $value): mixed
129-
{
130-
return class_exists(Json::class)
131-
? Json::encode($value)
132-
: json_encode($value);
133-
}
134-
135-
private function decode(string $payload, bool $associative = false): mixed
136-
{
137-
return class_exists(Json::class)
138-
? Json::decode($payload, ! $associative)
139-
: json_decode($payload, $associative);
140-
}
141126
}

0 commit comments

Comments
 (0)