Skip to content

Commit e0bfb70

Browse files
Revert changes from 3.2.1
1 parent 10bd995 commit e0bfb70

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
All notable changes to `laravel-query-builder` will be documented in this file
44

5+
## 3.2.2 - 2020-09-09
6+
7+
- Revert changes from v3.2.1 to `AllowedFilter::filter()`
8+
59
## 3.2.1 - 2020-09-09
610

711
- Fix filtering associative arrays (#488)

phpunit.xml.dist

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" backupGlobals="false" backupStaticAttributes="false" colors="true" verbose="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="true" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
3-
<coverage>
4-
<include>
5-
<directory suffix=".php">src/</directory>
6-
</include>
7-
</coverage>
83
<testsuites>
94
<testsuite name="Spatie Test Suite">
105
<directory>tests</directory>

src/AllowedFilter.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace Spatie\QueryBuilder;
44

5-
use Illuminate\Database\Eloquent\Builder;
65
use Illuminate\Support\Collection;
76
use Spatie\QueryBuilder\Filters\Filter;
87
use Spatie\QueryBuilder\Filters\FiltersCallback;
@@ -39,7 +38,7 @@ public function __construct(string $name, Filter $filterClass, ?string $internal
3938
$this->internalName = $internalName ?? $name;
4039
}
4140

42-
public function filter(Builder $query, $value)
41+
public function filter(QueryBuilder $query, $value)
4342
{
4443
$valueToFilter = $this->resolveValueForFiltering($value);
4544

0 commit comments

Comments
 (0)