$vendorViews Resolution Leading to Duplicate View Cache Files

[peterjbassi]

Hello,

We're noticing some duplication of files in Laravel's view cache (./storage/framework/views) for some packages on requests that come in well after php artisan view:cache has been run.

An example is in Filament Charts. The resolved paths from php artisan view:cache and laravel-package-tools are "different", so the hashes used to the name the cache files are different. This ultimately results in the file cached through php artisan view:cache being ignored, and a the new cached version being generated on the first relevant request. For our use case, this has resulted in some nasty race condition behavior with view cache files being read and written concurrently by concurrent requests, causing exceptions and other undesired behavior.

Ex:

php artisan view:cache:    /app/vendor/filament/widgets/resources/views/chart-widget.blade.php
laravel-package-tools:     /app/vendor/filament/widgets/src/../resources/views/chart-widget.blade.php

If we simply wrap Spatie\LaravelPackageTools\Concerns\PackageServiceProvider\ProcessViews:14 with a call to PHP's realpath() function, the duplicated cache issue (and other downstream problems) is resolved.

Before:
$vendorViews = $this->package->basePath('/../resources/views');

After:
$vendorViews = realpath($this->package->basePath('/../resources/views'));

Curious if anybody else has experienced this problem and/or has any suggestions to fix or work around it.

Thanks!

[peterjbassi]

For anybody reading, the difference here comes from the fact that php artisan view:cache (which runs Illuminate\Foundation\Console\ViewCacheCommand) actually does the "realpath" translation before compilation.

To work around the issue, we've overridden the Artisan command to include logic to produce the "duplicate" cache files that laravel-packge-tools would create at request-time.

Would be great to have the "realpath" logic worked into laravel-packge-tools though!