[Suggestions] Various improvements (backwards compatible)

[Sophist-UK]

1. The setBasePath() method is called in the register() method of the PackageServiceProvider class and thus cannot be explicitly set against the Package instance when it is created. This is based on an assumption that the PackageServiceProvider subclass is located in a sub-directory e.g. /Providers whereas it could be in /App/Providers or /. I would propose that the current default basePath is set in the Package constructor rather than in register() and thus can be overridden in the user's configurePackage() code like any other value.

2. The basePath is set to e.g. /Providers rather than / and then e.g. the config directory is ../config. I think it would be better to set the basePath to be / and have directories relative to that. Since setBasePath is currently user callable in ConfigurePackage() this change can currently be made backwards compatible.

3. You can then have new methods (e.g. setConfigPath) to define the relative paths for config, migrations etc. in order not to rely on hard coded assumptions about directory structure. (You would obviously need to have default values that could be overridden.)

4. hasConfigFile and hasViewComposer accept either a string or an array of strings, whilst most other methods have singular & plural versions to do the same thing, and this is inconsistent. I would suggest that all singular methods are changed to be mixed, and plural methods are synonyms.

5. Where methods take individual files (rather than directory/directories) as a parameter, it would be nice to provide the ability to specify '*' or ** as a file name, and for the package to iterate over suitable file names so that they do not need to be specified explicitly.

6. There are no type-hints for this package and IMO they would be beneficial.

[Sophist-UK]

On reflection, point 1. is already possible but undocumented. Point 2. would lose details of the directory the sub-class of PackageServiceProvider is located in, and cannot easily be implemented.