Merge pull request #120 from ryanhertz/MWEB-1217-defaultable-id

MWEB-1217: fixed symbol hash key bug in Defaultable

Author: bhornseth

CHANGELOG

@@ -1,3 +1,6 @@
+v1.4.4
+  - Fixed symbol hash key bug in Defaultable
+
 v1.4.3
  - Change Finders and Defaultable to handle an api response of an empty array when finding a single resource.
 

Guardfile

@@ -1,6 +1,6 @@
 
 guard :rspec, cmd: 'rspec' do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/unit/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
 end

VERSION

@@ -1 +1 @@
-1.4.3
+1.4.4

lib/spark_api/models/defaultable.rb

@@ -21,7 +21,7 @@ module ClassMethods
         def default(options = {})
           response = connection.get("/#{element_name}/default", options).first
           unless response.nil?
-            response[:Id] = DEFAULT_ID if response[:Id].nil?
+            response["Id"] = DEFAULT_ID if response["Id"].nil?
             new(response)
           end
         end

spec/unit/spark_api/models/defaultable_spec.rb

@@ -15,7 +15,7 @@ class TestClass < Base
   describe 'default' do
 
     it 'returns an instance of the class' do
-      allow(TestClass).to receive(:connection).and_return(double(get: [{Name: 'foo'}]))
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Name" => 'foo'}]))
       expect(TestClass.default).to be_a TestClass
     end
 
@@ -25,12 +25,12 @@ class TestClass < Base
     end
 
     it "assigns the default id to the instance if it doesn't have an id" do
-      allow(TestClass).to receive(:connection).and_return(double(get: [{Name: 'foo'}]))
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Name" => 'foo'}]))
       expect(TestClass.default.Id).to eq TestClass::DEFAULT_ID
     end
 
     it "doesn't override the id if one is present" do
-      allow(TestClass).to receive(:connection).and_return(double(get: [{Id: '5', Name: 'foo'}]))
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Id" => '5', "Name" => 'foo'}]))
       expect(TestClass.default.Id).to eq '5'
     end