fixed duplicate requests in NewsFeedMeta

Author: ryanhertz

CHANGELOG

@@ -1,3 +1,6 @@
+v1.4.14
+ - fixed duplicate requests in NewsFeedMeta
+
 v1.4.13
  - added SystemInfoSearch model
 

VERSION

@@ -1 +1 @@
-1.4.13
+1.4.14

lib/spark_api/models/news_feed_meta.rb

@@ -31,7 +31,11 @@ def core_fields
       private
 
       def data
-        @data ||= connection.get(self.path).first
+        if attributes.empty?
+          @data ||= connection.get(self.path).first
+        else
+          attributes
+        end
       end
 
     end

spec/unit/spark_api/models/news_feed_meta_spec.rb

@@ -10,6 +10,14 @@
     stub_api_get("/newsfeeds/meta", "newsfeeds/meta.json")
   end
 
+  describe 'fetching data' do
+    it "only makes one api request" do
+      news_feed_meta = NewsFeedMeta.get.first
+      news_feed_meta.minimum_core_fields
+      expect_api_request(:get, "/newsfeeds/meta").to have_been_made.once
+    end
+  end
+
   describe 'minimum_core_fields' do
     it 'returns the minimum number of required fields' do
       expect(news_feed_meta.minimum_core_fields).to eq 3