Merge branch 'master' into model-extractions

Author: bhornseth

CHANGELOG

@@ -1,3 +1,6 @@
+v1.4.8
+ - added ListingCart#add_listings
+
 v1.4.7
  - store 'D' attribute in responses
 

VERSION

@@ -1 +1 @@
-1.4.7
+1.4.8

lib/spark_api/models/listing_cart.rb

@@ -37,12 +37,16 @@ def listings(args = {})
         Listing.collect(connection.get("#{self.path}/#{self.Id}/listings", args))
       end
 
-      def add_listing(listing)
-        ids = listing.respond_to?(:Id) ? listing.Id : listing
-        results = connection.post("#{self.resource_uri}", {"ListingIds" => Array(ids)})
+      def add_listings(listings)
+        ids = Array(listings).map do |listing|
+          listing.respond_to?(:Id) ? listing.Id : listing
+        end
+        results = connection.post("#{self.resource_uri}", {"ListingIds" => ids})
         self.ListingCount = results.first["ListingCount"]
       end
 
+      alias_method :add_listing, :add_listings
+
       def remove_listing(listing)
         id = listing.respond_to?(:Id) ? listing.Id : listing.to_s
         results = connection.delete("#{self.class.path}/#{self.Id}/listings/#{id}")

spark_api.gemspec

@@ -38,6 +38,12 @@ Gem::Specification.new do |s|
   s.add_dependency 'will_paginate', '>= 3.0.pre2', '< 4.0.0'
   s.add_dependency 'highline', '>= 1.0'
 
+  # spark_api doesn't use public_suffix directly. spark_api uses Webmock, which 
+  # uses addressable, which uses public_suffix. Bundler has suddenly started 
+  # trying to install public_suffix 2.0.4, which requires Ruby 2. When spark_api 
+  # starts to require Ruby 2, this dependency can be removed.
+  s.add_dependency 'public_suffix', '~> 1.4.6'
+
   # TEST GEMS
   s.add_development_dependency 'rake', '~> 0.9.2'  
   s.add_development_dependency 'rspec', '~> 2.14.0'

spec/fixtures/listing_carts/add_listings.json

@@ -0,0 +1,13 @@
+{
+    "D": {
+        "Success": true,
+        "Results": [
+            {
+                "ResourceUri": "/v1/listingcarts/20100912153422758914000000",
+                "Id": "20100912153422758914000000",
+                "Name": "My Listing Cart",
+                "ListingCount": 12
+            }
+        ]
+    }
+}

spec/fixtures/listing_carts/add_listings_post.json

@@ -0,0 +1,5 @@
+ {
+    "D": {
+		 "ListingIds": [ "20110621133454434543000000", "20110621133454434543000001" ]
+	}
+ }

spec/unit/spark_api/models/listing_cart_spec.rb

@@ -76,6 +76,17 @@
       resource.ListingCount.should eq(11)
     end
 
+    on_post_it "should add multiple listings to a cart" do
+      listing_ids = ["20110621133454434543000000", "20110621133454434543000001"]
+      stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
+      resource = subject.class.get.first
+      resource.Id.should eq("20100912153422758914000000")
+      stub_api_post("/#{subject.class.element_name}/#{resource.Id}",'listing_carts/add_listings_post.json', 'listing_carts/add_listings.json')
+      resource.ListingCount.should eq(10)
+      resource.add_listings(listing_ids)
+      resource.ListingCount.should eq(12)
+    end
+
     on_delete_it "should delete a listing cart" do
       stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
       resource = subject.class.get.first