added tests for provided searches

Author: ryanhertz

lib/spark_api/models/saved_search.rb

@@ -22,6 +22,9 @@ def self.provided()
           def is_provided_search?
             true
           end
+          def newsfeeds
+            []
+          end
           SparkApi.logger.info("#{self.name}.path: #{provided.path}")
         end
       end
@@ -80,6 +83,7 @@ def is_provided_search?
       def can_have_newsfeed?
 
         return false if is_provided_search? 
+        return true  if has_active_newsfeed? || has_inactive_newsfeed?
 
         # Newsfeed restriction criteria for saved searches:
         # http://alpha.sparkplatform.com/docs/api_services/newsfeed/restrictions#criteria
@@ -96,6 +100,8 @@ def can_have_newsfeed?
       end
 
       def has_active_newsfeed?
+        return false if is_provided_search? 
+
         if self.respond_to? "NewsFeedSubscriptionSummary"
           self.NewsFeedSubscriptionSummary['ActiveSubscription']
         else
@@ -105,6 +111,8 @@ def has_active_newsfeed?
       end
 
       def has_inactive_newsfeed?
+        return false if is_provided_search? 
+       
         if self.respond_to? "NewsFeedSubscriptionSummary"
           !self.NewsFeedSubscriptionSummary['ActiveSubscription']
         else

spec/unit/spark_api/models/saved_search_spec.rb

@@ -148,6 +148,9 @@
     it "should return false without at least three filter parameters" do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
       resource = subject.class.find(id)
+      resource.stub(:is_provided_search?) { false }
+      resource.stub(:has_active_newsfeed?) { false }
+      resource.stub(:has_inactive_newsfeed?) { false }
       resource.Filter = "City Eq 'Moorhead' And MlsStatus Eq 'Active'"
       resource.can_have_newsfeed?.should == false
     end
@@ -156,6 +159,8 @@
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
       resource = subject.class.find(id)
       resource.stub(:is_provided_search?) { false }
+      resource.stub(:has_active_newsfeed?) { false }
+      resource.stub(:has_inactive_newsfeed?) { false }
       resource.can_have_newsfeed?.should == true
     end
 
@@ -166,7 +171,16 @@
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_newsfeed.json',
         { "_expand" => "NewsFeedSubscriptionSummary" } )
-      subject.class.find(id).has_active_newsfeed?.should == true
+      resource = subject.class.find(id)
+      resource.stub(:is_provided_search?) { false }
+      resource.has_active_newsfeed?.should == true
+    end
+
+    it "should return false for a provided search" do
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
+      resource = subject.class.find(id)
+      resource.stub(:is_provided_search?) { true }
+      resource.has_active_newsfeed?.should == false
     end
   end
 
@@ -175,18 +189,24 @@
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json')
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json',
         { "_expand" => "NewsFeedSubscriptionSummary" } )
-      subject.class.find(id).has_inactive_newsfeed?.should == true
+      resource = subject.class.find(id)
+      resource.stub(:is_provided_search?) { false }
+      resource.has_inactive_newsfeed?.should == true
+    end
+
+    it "should return false for a provided search" do
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json')
+      resource = subject.class.find(id)
+      resource.stub(:is_provided_search?) { true }
+      resource.has_inactive_newsfeed?.should == false
     end
   end
 
   describe "newsfeed" do
-
     it "should return the newsfeed for the saved search" do
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
-
       stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_newsfeed.json',
         { "_expand" => "NewsFeeds" } )      
-
       resource = subject.class.find(id)
       resource.newsfeeds.should be_an(Array)
     end