fixed bug in NewsFeedMeta core_fields and core_field_names

Calling either of those methods modified the data array when it should have only been reading the array. Later calls to these methods were then incorrect.

Author: ryanhertz

CHANGELOG

@@ -1,3 +1,6 @@
+v1.4.1
+ - Fixed bug in NewsFeedMeta core_fields and core_field_names. Calling either of those methods modified the data array when it should have only been reading the array. Later calls to these methods were then incorrect.
+
 v1.4.0
  - removed NewsFeedMeta and can_have_newsfeed? from SavedSearch
 

VERSION

@@ -1 +1 @@
-1.4.0
+1.4.1

lib/spark_api/models/news_feed_meta.rb

@@ -9,7 +9,7 @@ def minimum_core_fields
       end
 
       def core_field_names
-        fields = data['Subscriptions']['SavedSearches']['CoreSearchFields']
+        fields = data['Subscriptions']['SavedSearches']['CoreSearchFields'].dup
 
         data['Subscriptions']['SavedSearches']['CoreStandardFields'].each do |field|
           fields << field[1]['Label']
@@ -19,7 +19,7 @@ def core_field_names
       end
 
       def core_fields
-        fields = data['Subscriptions']['SavedSearches']['CoreSearchFields']
+        fields = data['Subscriptions']['SavedSearches']['CoreSearchFields'].dup
 
         data['Subscriptions']['SavedSearches']['CoreStandardFields'].each do |field|
           fields << field.first

spec/unit/spark_api/models/news_feed_meta_spec.rb

@@ -22,6 +22,13 @@
         "Year Built", "Total SqFt.", "Sub Type", "Subdivision", "Map Area"]
       expect(news_feed_meta.core_field_names).to eq field_array    
     end
+
+    it "doesn't modify the original fields and returns the same results when run twice" do
+      field_array = ["Location", "Status", "Property Type", "Postal Code", "List Price", "Total Bedrooms", 
+        "Year Built", "Total SqFt.", "Sub Type", "Subdivision", "Map Area"]
+      expect(news_feed_meta.core_field_names).to eq field_array    
+      expect(news_feed_meta.core_field_names).to eq field_array    
+    end
   end
 
   describe 'core_fields' do
@@ -30,6 +37,13 @@
         "YearBuilt", "BuildingAreaTotal", "PropertySubType", "SubdivisionName", "MLSAreaMinor"]
       expect(news_feed_meta.core_fields).to eq field_array    
     end
+
+    it "doesn't modify the original fields and returns the same results when run twice" do
+      field_array = ["Location", "MlsStatus", "PropertyType", "PostalCode", "ListPrice", "BedsTotal", 
+        "YearBuilt", "BuildingAreaTotal", "PropertySubType", "SubdivisionName", "MLSAreaMinor"]
+      expect(news_feed_meta.core_fields).to eq field_array    
+      expect(news_feed_meta.core_fields).to eq field_array    
+    end
   end
 
 end