adding newsfeeds method to saved searches model

Author: ryanhertz

lib/spark_api/models/base.rb

@@ -94,7 +94,7 @@ def method_missing(method_symbol, *arguments)
           end 
         else
           return attributes[method_name] if attributes.include?(method_name)
-          super # GTFO
+          super
         end
       end
 

lib/spark_api/models/finders.rb

@@ -31,11 +31,11 @@ def last(*arguments)
       private
 
       def find_every(options)
-        collect(connection.get("/#{element_name}", options))
+        collect(connection.get("#{path}", options))
       end
 
       def find_single(scope, options)
-        resp = connection.get("/#{element_name}/#{scope}", options)
+        resp = connection.get("#{path}/#{scope}", options)
         new(resp.first)
       end
 

lib/spark_api/models/listing.rb

@@ -233,7 +233,7 @@ def method_missing(method_symbol, *arguments)
         else 
           return attributes[method_name] if attributes.include?(method_name)
           return @attributes['StandardFields'][method_name] if attributes['StandardFields'].include?(method_name)
-          super # GTFO
+          super
         end
       end
 

lib/spark_api/models/saved_search.rb

@@ -6,8 +6,15 @@ class SavedSearch < Base
       include Concerns::Savable,
               Concerns::Destroyable
 
+      attr_accessor :newsfeeds
+
       self.element_name="savedsearches"
 
+      def initialize(attributes={})
+        @newsfeeds = nil
+        super(attributes)
+      end
+
       def self.provided()
         Class.new(self).tap do |provided|
           provided.element_name = '/savedsearches'
@@ -49,16 +56,14 @@ def contacts
         end
       end
 
-      # This section is on hold until https://jira.fbsdata.com/browse/API-2766 has been completed.
-      # 
-      # return the newsfeed attached to this saved search
-      # def newsfeeds
-      #   Newsfeed.find(:all, :_filter => "Subscription.Id Eq '#{@attributes["Id"]}'")
-      # end
-
-      # def newsfeed_for(user)
-      #   self.newsfeeds.select { |feed| feed.OwnerId == user.Id } 
-      # end
+      def newsfeeds
+        if @newsfeeds.nil?
+          response = SparkApi.client.get("/savedsearches/#{@attributes["Id"]}", _expand: "NewsFeeds").first["NewsFeeds"]
+              # the response from the api is just a bunch of hashes, but we can turn them into Newsfeed instances
+          @newsfeeds = response.map { |hash| Newsfeed.new(hash) }
+        end
+        @newsfeeds
+      end
 
       def can_have_newsfeed?
 

spec/fixtures/saved_searches/with_newsfeed.json

@@ -11,7 +11,24 @@
               ],
               "NewsFeedSubscriptionSummary": {
                 "ActiveSubscription": true
-              }
+              },
+              "NewsFeeds": [
+                {
+                  "ResourceUri": "/v1/newsfeeds/20141203082619076323088319",
+                  "Name": "My Very Special Newsfeed",
+                  "OwnerId": "20000426143505724628000000",
+                  "ProspectLinkId": "",
+                  "CreatedTimestamp": "2014-12-03T08:26:19Z",
+                  "Id": "20141203082619076323088319",
+                  "Active": "true",
+                  "ModificationTimestamp": "2014-12-03T08:26:19Z",
+                  "ExpirationDate": "2015-03-03",
+                  "Curated": "false",
+                  "NotificationMethods": ["Email"],
+                  "LastEventTimestamp": "",
+                  "Type": "SavedSearch"
+                }
+              ]
             }
         ]
     }

spec/unit/spark_api/models/saved_search_spec.rb

@@ -176,4 +176,17 @@
 
   end
 
+  describe "newsfeed" do
+
+    it "should return the newsfeed for the saved search" do
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
+
+      stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_newsfeed.json',
+        { "_expand" => "NewsFeeds" } )      
+
+      resource = subject.class.find(id)
+      resource.newsfeeds.should be_an(Array)
+    end
+  end
+
 end