CUR-19507 Adding batch_photo_delete to Listing (#128)

* CUR-19507 Add batch photo delete.

* Small tweaks to work with the finished API.
And bumping the version number.

* Add newline to end of .gitignore

* Fixing batch_photo_delete
Expect a string of IDs instead of an array.

* Addressing PR feedback
* Added a unit test
* Updated listing.rb to have a safe and dangerous version of batch_photo_delete
* Bumped version number one more.

* Fixing up more PR feedback.
* Updated naming from batch_photo_delete to delete_photos
* Updated the dangerous delete_photos to return true.
* Updated unit test to actually assert something.

* DRYing things up a bit

* Picking nits.

Author: stmott

VERSION

@@ -1 +1 @@
-1.4.10
+1.4.11

lib/spark_api/models/listing.rb

@@ -188,7 +188,7 @@ def reorder_photos(arguments={})
         false
       end
       def reorder_photos!(arguments={})
-        results = connection.put "#{self.class.path}/#{self.Id}/photos", arguments
+        results = connection.put subresource_path("photos"), arguments
         true
       end
 
@@ -207,7 +207,7 @@ def reorder_photo(photo_id, index)
         false
       end
       def reorder_photo!(photo_id, index)
-        connection.put "#{self.class.path}/#{self.Id}/photos/#{photo_id}", "Photos" => [{"Order"=>index}]
+        connection.put subresource_path("photos") + "/#{photo_id}", "Photos" => [{"Order"=>index}]
         true
       end
 
@@ -235,6 +235,26 @@ def respond_to?(method_symbol, include_all=false)
         end
       end
 
+      def delete_photos!(photoIds, args={})
+        connection.delete subresource_path("photos") + "/#{photoIds}", args
+        true
+      end
+
+      def delete_photos(photoIds, args={})
+        unless photoIds.is_a? String
+          raise ArgumentError, "Batch photo delete failed. '#{photoIds}' is not a string."
+        end
+
+        begin
+          return delete_photos!(photoIds, args)
+        rescue BadResourceRequest => e
+          SparkApi.logger.warn { "Failed to delete photos from resource #{self}: #{e.message}" }
+        rescue NotFound => e
+          SparkApi.logger.error { "Failed to delete photos from resource #{self}: #{e.message}" }
+        end
+        false
+      end
+
       private
 
       # TODO trim this down so we're only overriding the StandardFields access
@@ -272,6 +292,10 @@ def setup_attribute(attributes, collection, klass)
         end
       end
 
+      def subresource_path(subresource)
+        "#{self.class.path}/#{self.Id}/#{subresource}"
+      end
+
     end
   end
 end

spec/unit/spark_api/models/listing_spec.rb

@@ -351,6 +351,16 @@
           l.editable?(:PriceChange).should eq(true)
           l.editable?(:Photos).should eq(false)
         end
+
+        on_delete_it "should bulk delete listing photos" do
+          list_id = "20060725224713296297000000"
+          stub_api_get("/listings/#{list_id}", 'listings/with_photos.json', { :_expand => "Photos" })
+          l = Listing.find(list_id, :_expand => "Photos")
+          photo_id1 = l.photos[0].Id
+          photo_id2 = l.photos[1].Id
+          stub_api_delete("/listings/#{list_id}/photos/#{photo_id1},#{photo_id2}", 'success.json')
+          l.delete_photos(photo_id1 + "," + photo_id2).should be(true)
+        end
       end
     end