Merge pull request #93 from ryanhertz/throw-error-when-finder-arg-is-nil

Raise error on `nil` argument to find()

Author: mjobrien

lib/spark_api/models/finders.rb

@@ -8,6 +8,7 @@ def find(*arguments)
         scope = arguments.slice!(0)
         options = arguments.slice!(0) || {}
         case scope
+          when nil    then raise ArgumentError, "Argument for find() can't be nil"
           when :all   then find_every(options)
           when :first then find_every(options).first
           when :last  then find_every(options).last

spec/unit/spark_api/models/finders_spec.rb

@@ -32,4 +32,21 @@ class MyResource < Base
     resource.Id.should eq(1)
   end
 
+  describe "find" do
+
+    it "should throw an error if no argument is passed" do
+      stub_api_get("/my_resource/", 'finders.json')
+      lambda {
+        MyResource.find()
+      }.should raise_error(ArgumentError)
+    end
+
+    it "should throw an error when the first argument is nil" do
+      stub_api_get("/my_resource/", 'finders.json', {:_limit => 1})
+      lambda {
+        MyResource.find(nil, {:_limit => 1})
+      }.should raise_error(ArgumentError)
+    end
+
+  end
 end