Skip to content

Commit 4f81420

Browse files
committed
Merge pull request #91 from sparkapi/FLEX-987
FLEX-987: Handle missing unparsed first line address.
2 parents 9310597 + b630a0f commit 4f81420

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

lib/spark_api/models/listing.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def shared_notes(fore=nil)
129129
end
130130

131131
def street_address
132-
self.UnparsedFirstLineAddress.delete(DATA_MASK).strip().gsub(/\s{2,}/, ' ')
132+
(self.UnparsedFirstLineAddress || '').delete(DATA_MASK).strip().gsub(/\s{2,}/, ' ')
133133
end
134134

135135
def region_address

spec/unit/spark_api/models/listing_spec.rb

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,22 @@
8787
@listing.should_not respond_to(:Videos)
8888
end
8989

90-
it "should return street address" do
91-
@listing.street_address.should eq("100 Someone's St")
92-
end
90+
describe '.street_address' do
91+
it 'should return the street address' do
92+
@listing.street_address.should eq("100 Someone's St")
93+
end
94+
95+
it 'should remove data masks' do
96+
@listing.StandardFields["UnparsedFirstLineAddress"] = "********"
97+
@listing.street_address.should eq("")
98+
end
9399

94-
it "should remove masks from the street address" do
95-
@listing.StandardFields["UnparsedFirstLineAddress"] = "********"
96-
@listing.street_address.should eq("")
100+
it 'should handle a missing unparsed first line address' do
101+
[nil, '', ' '].each do |current|
102+
@listing.StandardFields['UnparsedFirstLineAddress'] = current
103+
@listing.street_address.should eq('')
104+
end
105+
end
97106
end
98107

99108
it "should return the regional address" do

0 commit comments

Comments
 (0)