moved qualifying_fields_for_newsfeed to contstant

Author: ryanhertz

lib/spark_api/models/saved_search.rb

@@ -8,6 +8,11 @@ class SavedSearch < Base
 
       attr_accessor :newsfeeds
 
+      # Newsfeed restriction criteria for saved searches:
+      # http://alpha.sparkplatform.com/docs/api_services/newsfeed/restrictions#criteria
+      QUALIFYING_FIELDS_FOR_NEWSFEED = %w(BathsTotal BedsTotal City CountyOrParish ListPrice Location MlsStatus 
+        PostalCode PropertyType RoomsTotal State)
+
       self.element_name="savedsearches"
 
       def initialize(attributes={})
@@ -74,24 +79,13 @@ def provided_search?
         false
       end
 
-      def self.qualifying_fields_for_newsfeed
-        # Newsfeed restriction criteria for saved searches:
-        # http://alpha.sparkplatform.com/docs/api_services/newsfeed/restrictions#criteria
-        %w(BathsTotal BedsTotal City CountyOrParish ListPrice Location MlsStatus PostalCode PropertyType 
-          RoomsTotal State)
-      end
-
-      def qualifying_fields_for_newsfeed
-        self.class.qualifying_fields_for_newsfeed
-      end
-
       def can_have_newsfeed?
 
         return true  if has_active_newsfeed? || has_inactive_newsfeed?
 
         number_of_filters = 0
 
-        self.class.qualifying_fields_for_newsfeed.each do |field|
+        QUALIFYING_FIELDS_FOR_NEWSFEED.each do |field|
           number_of_filters += 1 if self.Filter.include? field
         end
 

spec/unit/spark_api/models/saved_search_spec.rb

@@ -238,9 +238,9 @@
     end
   end
 
-  describe "qualifying_fields_for_newsfeed" do
+  describe "QUALIFYING_FIELDS_FOR_NEWSFEED" do
     it "should return an array" do
-      subject.class.qualifying_fields_for_newsfeed.should be_an(Array)
+      subject.class::QUALIFYING_FIELDS_FOR_NEWSFEED.should be_an(Array)
     end
   end