Skip to content

Commit 1e94abf

Browse files
committed
changed is_provided_search? to provided_search?
1 parent cef2c18 commit 1e94abf

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

lib/spark_api/models/saved_search.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def self.provided()
1919
Class.new(self).tap do |provided|
2020
provided.element_name = '/savedsearches'
2121
provided.prefix = '/provided'
22-
def is_provided_search?
22+
def provided_search?
2323
true
2424
end
2525
def newsfeeds
@@ -76,13 +76,13 @@ def newsfeeds
7676
@newsfeeds
7777
end
7878

79-
def is_provided_search?
79+
def provided_search?
8080
false
8181
end
8282

8383
def can_have_newsfeed?
8484

85-
return false if is_provided_search?
85+
return false if provided_search?
8686
return true if has_active_newsfeed? || has_inactive_newsfeed?
8787

8888
# Newsfeed restriction criteria for saved searches:
@@ -100,7 +100,7 @@ def can_have_newsfeed?
100100
end
101101

102102
def has_active_newsfeed?
103-
return false if is_provided_search?
103+
return false if provided_search?
104104

105105
if self.respond_to? "NewsFeedSubscriptionSummary"
106106
self.NewsFeedSubscriptionSummary['ActiveSubscription']
@@ -111,7 +111,7 @@ def has_active_newsfeed?
111111
end
112112

113113
def has_inactive_newsfeed?
114-
return false if is_provided_search?
114+
return false if provided_search?
115115

116116
if self.respond_to? "NewsFeedSubscriptionSummary"
117117
!self.NewsFeedSubscriptionSummary['ActiveSubscription']

spec/unit/spark_api/models/saved_search_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,14 +141,14 @@
141141
it "should return false for a provided search" do
142142
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
143143
resource = subject.class.find(id)
144-
resource.stub(:is_provided_search?) { true }
144+
resource.stub(:provided_search?) { true }
145145
resource.can_have_newsfeed?.should == false
146146
end
147147

148148
it "should return false without at least three filter parameters" do
149149
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
150150
resource = subject.class.find(id)
151-
resource.stub(:is_provided_search?) { false }
151+
resource.stub(:provided_search?) { false }
152152
resource.stub(:has_active_newsfeed?) { false }
153153
resource.stub(:has_inactive_newsfeed?) { false }
154154
resource.Filter = "City Eq 'Moorhead' And MlsStatus Eq 'Active'"
@@ -158,7 +158,7 @@
158158
it "should return true with three filter parameters" do
159159
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
160160
resource = subject.class.find(id)
161-
resource.stub(:is_provided_search?) { false }
161+
resource.stub(:provided_search?) { false }
162162
resource.stub(:has_active_newsfeed?) { false }
163163
resource.stub(:has_inactive_newsfeed?) { false }
164164
resource.can_have_newsfeed?.should == true
@@ -172,14 +172,14 @@
172172
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_newsfeed.json',
173173
{ "_expand" => "NewsFeedSubscriptionSummary" } )
174174
resource = subject.class.find(id)
175-
resource.stub(:is_provided_search?) { false }
175+
resource.stub(:provided_search?) { false }
176176
resource.has_active_newsfeed?.should == true
177177
end
178178

179179
it "should return false for a provided search" do
180180
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/get.json')
181181
resource = subject.class.find(id)
182-
resource.stub(:is_provided_search?) { true }
182+
resource.stub(:provided_search?) { true }
183183
resource.has_active_newsfeed?.should == false
184184
end
185185
end
@@ -190,14 +190,14 @@
190190
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json',
191191
{ "_expand" => "NewsFeedSubscriptionSummary" } )
192192
resource = subject.class.find(id)
193-
resource.stub(:is_provided_search?) { false }
193+
resource.stub(:provided_search?) { false }
194194
resource.has_inactive_newsfeed?.should == true
195195
end
196196

197197
it "should return false for a provided search" do
198198
stub_api_get("/#{subject.class.element_name}/#{id}", 'saved_searches/with_inactive_newsfeed.json')
199199
resource = subject.class.find(id)
200-
resource.stub(:is_provided_search?) { true }
200+
resource.stub(:provided_search?) { true }
201201
resource.has_inactive_newsfeed?.should == false
202202
end
203203
end

0 commit comments

Comments
 (0)